From: Marc Zyngier <marc.zyngier@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Aisheng Dong <aisheng.dong@nxp.com>,
Fugang Duan <fugang.duan@nxp.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/imx-irqsteer: fix of_property_read_u32() error handling
Date: Mon, 04 Mar 2019 21:14:52 +0000 [thread overview]
Message-ID: <86d0n61gvn.wl-marc.zyngier@arm.com> (raw)
In-Reply-To: <20190304200245.1196001-1-arnd@arndb.de>
On Mon, 04 Mar 2019 20:02:18 +0000,
Arnd Bergmann <arnd@arndb.de> wrote:
>
> gcc points out that irqs_num is not initialized when of_property_read_u32()
> is an empty stub function:
>
> Included from drivers/irqchip/irq-imx-irqsteer.c:7:
> drivers/irqchip/irq-imx-irqsteer.c: In function 'imx_irqsteer_probe':
> include/uapi/linux/kernel.h:13:49: error: 'irqs_num' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The same can actually happen with CONFIG_OF=y as well, though we don't
> get a warning then.
>
> Add error checking here that lets the code deal with missing or
> invalid properties as well as avoid the warning.
>
> Fixes: 28528fca4908 ("irqchip/imx-irqsteer: Add multi output interrupts support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/irq-imx-irqsteer.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks Arnd.
M.
--
Jazz is not dead, it just smell funny.
prev parent reply other threads:[~2019-03-04 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:02 Arnd Bergmann
2019-03-04 21:14 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d0n61gvn.wl-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®