From: Krzysztof Kozlowski <krzk@kernel.org>
To: 周寅 <zain_zhou@realsil.com.cn>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Frank Li" <Frank.Li@nxp.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lee Jones" <lee@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Vikash Bansal" <vikash.bansal@nxp.com>,
"Aman Kumar Pandey" <aman.kumarpandey@nxp.com>,
"Lakshay Piplani" <lakshay.piplani@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mfd@lists.linux.dev" <mfd@lists.linux.dev>,
王炜 <wei_wang@realsil.com.cn>
Subject: Re: 回复: [RFC PATCH 3/4] regulator: rts490x: Add driver for on-die regulators
Date: Mon, 21 Sep 2026 16:07:02 +0200 [thread overview]
Message-ID: <86d282f5-9221-4a62-85db-2d46524dd817@kernel.org> (raw)
In-Reply-To: <fe92f1275efe4451978fc473cbad39dc@realsil.com.cn>
On 21/09/2026 05:46, 周寅 wrote:
> On Sun, Sep 20, 2026, Krzysztof Kozlowski wrote:
>> You leak OF nodes.
>
> Thanks for the review.
>
> Both regulators and node are declared with __free(device_node), so the
> references returned by of_get_available_child_by_name() should be
> dropped on scope exit, including the continue and error paths.
>
> Could you clarify which reference is leaking?
I missed the __free, but then why do you declare __free variable with
NULL as constructor? Don't grow this pattern. See cleanup.h (or
discussions on the lists).
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-21 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 10:04 [RFC PATCH 0/4] Add support for Realtek RTS490x I3C hub zain_zhou
2026-09-20 10:04 ` [RFC PATCH 1/4] dt-bindings: i3c: Add Realtek RTS490x I3C hub support zain_zhou
2026-09-20 10:04 ` [RFC PATCH 2/4] mfd: Add driver for Realtek RTS490x I3C hub zain_zhou
2026-09-20 10:05 ` [RFC PATCH 3/4] regulator: rts490x: Add driver for on-die regulators zain_zhou
2026-09-20 13:05 ` Krzysztof Kozlowski
2026-09-21 3:46 ` 回复: " 周寅
2026-09-21 14:07 ` Krzysztof Kozlowski [this message]
2026-09-21 10:23 ` Mark Brown
2026-09-20 10:05 ` [RFC PATCH 4/4] i3c: hub: Add Realtek RTS490x I3C hub support zain_zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d282f5-9221-4a62-85db-2d46524dd817@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=aman.kumarpandey@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lakshay.piplani@nxp.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=vikash.bansal@nxp.com \
--cc=wei_wang@realsil.com.cn \
--cc=zain_zhou@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®