From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46A2335CB94 for ; Tue, 27 Jan 2026 22:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769552812; cv=none; b=XG0gNEeX8VGxMxK3E8r64E0/tfD/I1oRKWA/XnKPwlVkgzbCF61qmtvDBPxFSVNg47ARiABZSy7h9RQ7CBn2T1yBVOAk/rwq3MGlakSsBOriJ3XC+NDGfgqzFrYq+kG6h2eZpgaEnTxLLRrtw1+/cU+zitYonyUIwVPQfr/EJvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769552812; c=relaxed/simple; bh=smVYfjKI9+K/W+GPz21M2ajvRHbJ20ADwbev3uGYGBU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TuXg23UbgUnLmaLSftHJmBV4+qD0Mu5TQtWXKDxMTkRyL3DLJ9uFUb1GkirvF8Bl8QARd+GWMClG/2Oe8dPQi/qf44tLVIF3GyJKBJt9mIVHCAxov9rosUBrvpUJ8oxiRprtlrWs4khsBzOvR9eUi0JqZzKdSpzcTPVht/9uL7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ldh7SYeq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cFFGkjP1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ldh7SYeq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cFFGkjP1" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60REZrma1066201 for ; Tue, 27 Jan 2026 22:26:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /SjPWpC67opAaYXZUS7OC9NNECnpHUQAa71IYbObk1Y=; b=ldh7SYeqDUz9rRNl /HjDP13oFgbSQ6/h0H9zljCre1eXmzIpAfSQPDeGLtEg/EkkjlQibACnYlYeeZEJ gSs2dowBpOdnkf5xzBt8MpE0f8JggxYhGgCSTFJ/R6mlD6fozZxPUqDPH5uUcw29 6FqKOinQwSVPUrQVVk0DjfxsqFJTyOVfoQMhNVfkhBp9m6+epVlJLcOMSIHZ5Soi NHYBr4GgCG5AORYGSVEOKqPhvKEBmDaNJnpaF17cr2q5b+TmfLN5dcd+2yg+lEa8 uQfCDaF5IXXgeh259qsKTlp1dpAyCxtPgBGPB2WyakZ8QDDVJzjvKjX6Vcl/Vmzm Qgbc6A== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxy8x1hv9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 22:26:49 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2b74aff34efso5927171eec.1 for ; Tue, 27 Jan 2026 14:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769552809; x=1770157609; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/SjPWpC67opAaYXZUS7OC9NNECnpHUQAa71IYbObk1Y=; b=cFFGkjP1si6vOV90DNNKr8K9eUYVJgt77PbcwAtqa9wiNvXSE1vAu/SvWcljWHlv3S tbkV+B+hLlEyPkNZ8BOd6gA9c5ju5YvZDiH8ydkusi1X6Rf+7rfz5rJb5K8uxcPYwql8 WQq0io9FtyJ4/nWkbjZVrmNYKlX5QJKI25eZ9/g/K0Gjf6HL15VVI99HRqn13TVjIM1D NPrxszuDilaEjWSosq9TCqShvkHRqpHhYoe7MzoPby+Ilw04KqSFyWO7RxfrYFKpKbgT bsrLysZ9Y/WfJwt3PiGSTzwxrenFEyMCY0QGg1j+2rWhd36uZ1cO7L3oWkX/j8Yn+ho5 TY+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769552809; x=1770157609; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/SjPWpC67opAaYXZUS7OC9NNECnpHUQAa71IYbObk1Y=; b=Ko1lADJXcnxSX4BsgKhf6wQwwprpVlWfNt/jmhmKdG+kcx/H3iVX5GUF7C7LP6MeE7 DYgG/fD+bxZep/Ssp/bwvfZR/DJCB/urkYotUbt6+QKoNkex1f4GO42k2F0qFnKptgqJ nk/qhb5AgsJydKQtbNPw0LklvlVrpi0XivusvH6B3LWWr+ApHZKv/lcl+zeLFWRv4CsF pdLVDpfXaQvFtbmEkPtc8CNgdBTLWNJ5/2ZPQ9BF0eDl23RGuw4T95OtsFGJwsB5OmJU Eg06ZR66QKEE659bXOGmY8g6ca5z+auxC07BxLPTHAHxBmM01dNX/dTAholwdvzE/KCs iTAw== X-Forwarded-Encrypted: i=1; AJvYcCXjdjTO4frSGs9EnpMkWJ4CV46OLJq4SmCC0Y2YW+AxTvlf4F5EV/xZbe1SSn13MyUM6YBM07+jCE1+ey4=@vger.kernel.org X-Gm-Message-State: AOJu0YzgYRKKh+pvgZq2ALXr6rcB4ZVEq51lwHfVFa57X61oxWvI0ncy KiGEkPHiLxRV/yIVx7EBfIhMoKoWbDvoH6+a9q6GrPBwt1jx9ZI0UBAPD8zJBEjcG2MMVSVIEbU Syb5jcR/H4mbane565vbOqJqq3zRKbSQUxiXUQSz/Rt82LJKor5a84P3HMtUhxpoiJWc= X-Gm-Gg: AZuq6aKZ8Gw10B6H29sGbE3eRtsn9wt9oO5pWX+6g4qrtDbipmhjMckzowu/9psRo7m Ux9P8tcB4cqehknIlG28cHAYVpghCn4fqXKbaiL88DmXPW4OJ+qoXJr5a7hG6Ivo3z+tVsdVifZ MNcZrUqE7WPC/pKoi0T/K3PMPGzKsaZjbAM+jfQhIkGb6jE+EBIYN9kZvoH4s33BMtzppiRuUKV 3YyhxtwZJsY3wKPp5weGwWyhjBYjZV+62NLnlyItp4HNYeC/f4fUCEG3KRuPDxJgX9r6OVwM03R w88ZR8XI2Imm3fn4/tOOlKlska7tgysiwzdtXD0wMGIRD1GMA9wlIrc6rdSxDwTh4yVqhPnF3Dy KUGfwtSAb+axHcYdjWwV68QivDaIPcGtm0kbLxpfErGyB0GAKOlnUjFd9 X-Received: by 2002:a05:7300:cc12:b0:2b1:7486:3a6e with SMTP id 5a478bee46e88-2b78d90e3e7mr2073653eec.12.1769552808810; Tue, 27 Jan 2026 14:26:48 -0800 (PST) X-Received: by 2002:a05:7300:cc12:b0:2b1:7486:3a6e with SMTP id 5a478bee46e88-2b78d90e3e7mr2073624eec.12.1769552808288; Tue, 27 Jan 2026 14:26:48 -0800 (PST) Received: from [10.73.54.120] (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a16ef40asm97762eec.13.2026.01.27.14.26.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 14:26:47 -0800 (PST) Message-ID: <86dade1c-3ac4-4352-8dc8-e7acaaf21321@oss.qualcomm.com> Date: Tue, 27 Jan 2026 14:26:47 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/3] arm64: dts: qcom: glymur: Add USB related nodes To: Konrad Dybcio , Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng , Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> <01de4054-eebf-4ef3-ad74-c806b208a848@oss.qualcomm.com> <6lieos5uudkgynizozrmzrj5ov57frzzl65b2fpanwbhbmehot@z5uhyv4ipyet> <4632ad3a-c893-449a-b0d1-48d9c93da7e9@oss.qualcomm.com> Content-Language: en-US From: Wesley Cheng In-Reply-To: <4632ad3a-c893-449a-b0d1-48d9c93da7e9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: gbWXxUIAYrEH3lhBrdqFge0tETpQLYdF X-Authority-Analysis: v=2.4 cv=OcWVzxTY c=1 sm=1 tr=0 ts=69793ba9 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ZdW6uxA9NKXbfdqeeS2OGA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=PwVsVxMXDES1znWPHDIA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-ORIG-GUID: gbWXxUIAYrEH3lhBrdqFge0tETpQLYdF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDE4MiBTYWx0ZWRfX+kwrzS92d8zV X5JZNKQJoYuJc8CXbN++yXsZQooq3ca66tSJ11g8hqWtxho7+mMRAiCBlZnxYJg+LcbbqwZdrbL Y2KKwkEIu5Sndv+QE74gleY110sbYrMONPgpy95IaFNHqTqjc59JBKF/j8MgIIO5z0uZWfMF+gD +yrCJUt5FjF23KSYbtzPjYCFHIeZi/et3rw7byPDOyCDOk0vcJXse41sDMUzoIwMLk2ynb6lzJ2 6O0D1jYp0w1eMYdPtLRGnz/cjrJIB5g0D8HR+5tNeF9RAXnwzBP6U73TpE1ndiY8rdjlxVQ6Pbh AWSU2dy2n+SkLYJhB3+o4CSgG9xhyLISFS5SlJQbXkYlCh1n/l8LSMj8aDUonUy7LYEZS7iwwTK 3JwYgGvW0F4luZQLbvJ3VPznpCgFCZE5E03Cnr+7hatN/A3l/d0e1dNN/y4T6RYfPsCaos1O67I UXFgt+MOwmu7SkLVPvw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_04,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270182 On 1/27/2026 3:46 AM, Konrad Dybcio wrote: > On 1/27/26 12:41 PM, Abel Vesa wrote: >> On 26-01-13 14:13:32, Konrad Dybcio wrote: >>> On 1/13/26 1:33 PM, Abel Vesa wrote: >>>> From: Wesley Cheng >>>> >>>> The Glymur USB system contains 3 USB type C ports, 1 USB multiport >>>> controller and a USB 2.0 only controller. This encompasses 5 SS USB QMP >>>> PHYs (3 combo and 2 uni) and 6 M31 eUSB2 PHYs. All controllers are SNPS >>>> DWC3 based, so describe them as flattened DWC3 QCOM nodes. >>>> >>>> Signed-off-by: Wesley Cheng >>>> Co-developed-by: Abel Vesa >>>> Signed-off-by: Abel Vesa >>>> --- >>> >>> [...] >>> >>>> + snps,dis_u2_susphy_quirk; >>>> + snps,dis_enblslpm_quirk; >>>> + snps,dis_u3_susphy_quirk; >>>> + snps,usb2-lpm-disable; >>> >>> Other SoCs have a list that's much longer, please consult Wesley if >>> this list is enough >> >> Checked with Wesley. He confirmed that this trimmed list is fine. >> He said he dropped the rest since they are related to the power saving >> features like USB2/3 LPM (l1 or u1/u2) and we don't seem need those. > > Is that to say that those erratas were fixed in this hardware? > > Low-power states of the link are no less than desired is possible.. > I think it was misunderstood. We should keep the same quirks as our previous targets to enable USB LPM support in certain cases. snps,hird-threshold = /bits/ 8 <0x0>; snps,usb2-gadget-lpm-disable; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; snps,is-utmi-l1-suspend; snps,usb3_lpm_capable; snps,has-lpm-erratum; tx-fifo-resize; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; snps,usb2-lpm-disable; There are some questionable ones that I'm on the fence though, which we should consider removing: snps,usb2-lpm-disable snps,usb2-gadget-lpm-disable USB L1 support is routinely being verified on our devices (in host and device modes), so if its power over performance, we should consider removing the properties to disable USB L1. (esp since we're defining the HIRD threshold as well...) Thanks Wesley Cheng