From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04E1F426ECC for ; Wed, 4 Feb 2026 16:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222051; cv=none; b=iVpU0Lod6svJmE1UJYVVJzF5WiOKSM4MdhsgI5fBDBo7/TJtyWRNdN9amuPDoQlzzWi9hQpq9iwdec3dUyJ5J7nGHfQ+PgpjiAc3ulC+wd42F5JPARUDTZO7A2MP4JwYO/7tSM50zmXlJzRI6tr9liIOW6hYb+fSXF6Z2AeWUuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222051; c=relaxed/simple; bh=bCsWcmuvWqyAkQYJ55dTHHYIrLPc0AAF3OiXhbnms/I=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=kkaz27vNQFuJQ6jr30ITAfahaBDAadngoKOuJsYt2lGI9lW/JttJCyIqKxC9slDvMIt1xW/gtm70cv409vP01qPnDXeSy9xnvhksnkyaQqkc4NeKFmKb2WetQfT9JcCfJVuR4AupXnCbewpA6Dahw2mvCLd/E+Ua33tEacdGMsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=UIH6q5ar; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=bwHZOiMv; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="UIH6q5ar"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="bwHZOiMv" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 161EE14002D7; Wed, 4 Feb 2026 11:20:50 -0500 (EST) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-04.internal (MEProxy); Wed, 04 Feb 2026 11:20:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1770222050; x=1770308450; bh=p09IPGMFhf8prslelvdOSUxhojehn7stRQ3IV+IamUQ=; b= UIH6q5arT6SobTMB8jcIaPPb0WFr86mHeZTZ3Kc/wPEbLyqo99yJKvcO7PiGRKd3 1Hk7XZsQBVI3fpwA70mDFAdsVdy1t/XRMs0mXhUEIdxg8ZS/GJ/8YslkHe/P82wu pYy1pPh/cTs03bMagylnWm5CDzzBXGMdccRCuC4JBL+5qH2WHqeObS5fyqu3OMLj sqQocPZqi2QhjAZbxNKQbcl3gUr7rQo1VgRI3jyxROcPVwqjgGj5n8UewpkZrU4L +6BELxwG8TNnt/VOn8vBTaY+WbKaJnOIom3DQ1dmpGC7ik5khx/fa89rZ4EFN9wh LMrurBiItQcgQrdC8aldSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1770222050; x= 1770308450; bh=p09IPGMFhf8prslelvdOSUxhojehn7stRQ3IV+IamUQ=; b=b wHZOiMv+zAlDVUohr8p0avKZkw9KvxY9G51OJ00Q49aR+CCM1XUMR3ZLKF8fFs1n ea4azN5GVJvZRyapjV+2yYvyA6J5In6PSZ8Lo197wgVrfxfqhCkhFXxwRZUFirRj iPDba48uCX0yae210Awr8AsuxkTPKCtd4OUpiK74F06vn+js7K7uiVGaVx8EEZ5Y YX0vuHHReCdfl1sMUAU1lfMcGoItXjZagdpe7zDxN+7IrxaOYysk7lSCc2xU2AYx FrHSVf5Fx0+NMvSXwpXCFWwaXqtYYcyviFvjcSlzkMm0If1/gYGVMo6BeP/l4oTr 1JiXMeCe1cBjnVhZJ5VDA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddukedvledtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdejnecuhfhrohhmpedftehrnhgu uceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrthhtvg hrnhepvdfhvdekueduveffffetgfdvveefvdelhedvvdegjedvfeehtdeggeevheefleej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnh gusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepjhgrtghkmhgrnhgssehgohhoghhlvgdrtghomhdprhgtphhtthhope hpvghtvghriiesihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopegrkhhpmheslhhi nhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtoheprghnughrihihrdhshh gvvhgthhgvnhhkoheslhhinhhugidrihhnthgvlhdrtghomhdprhgtphhtthhopehlihhn uhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 03A8B700065; Wed, 4 Feb 2026 11:20:49 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AlwEaSADVN6N Date: Wed, 04 Feb 2026 17:20:27 +0100 From: "Arnd Bergmann" To: "Andy Shevchenko" , "Peter Zijlstra" , linux-kernel@vger.kernel.org Cc: "Andrew Morton" , "Brendan Jackman" Message-Id: <86e45719-b97e-4b70-92ba-415eecbf3a5a@app.fastmail.com> In-Reply-To: References: <20251208141618.2805983-1-andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v1 1/1] bug: Mark __warn_printf() with __printf() attribute Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Feb 4, 2026, at 16:59, Andy Shevchenko wrote: > +Cc: Arnd (just FYI) > > On Mon, Dec 08, 2025 at 03:16:18PM +0100, Andy Shevchenko wrote: >> __warn_printf() is using printf() type of format, and compiler >> is not happy about them as is: >>=20 >> lib/bug.c:187:25: error: function =E2=80=98__warn_printf=E2=80=99 mig= ht be a candidate for =E2=80=98gnu_printf=E2=80=99 format attribute [-We= rror=3Dsuggest-attribute=3Dformat] >> 187 | vprintk(fmt, *args); >> | ^~~~~~~ >>=20 >> Fix the compilation errors by adding __printf() attribute. >>=20 >> Fixes: 5c47b7f3d1a9 ("bug: Add BUG_FORMAT_ARGS infrastructure") >> Signed-off-by: Andy Shevchenko Yes, I think this is the correct fix. However, Brendan's patch is now in the tip tree as d36067d6ea00 ("bug: Hush suggest-attribute=3Dformat for __warn_printf()"). I hadn't seen your patch but did notice as well that the one that was merged is not ideal. I decided against sending a fixup because it looks harmless, but if you want to rebase your patch, feel free to add Acked-by: Arnd Bergmann Arnd