From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757975AbcG0SaC (ORCPT ); Wed, 27 Jul 2016 14:30:02 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:42968 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757863AbcG0S35 (ORCPT ); Wed, 27 Jul 2016 14:29:57 -0400 Subject: Re: [GIT PULL] f2fs for 4.8 To: Linus Torvalds , Jaegeuk Kim References: <20160727040800.GA69756@jaegeuk> CC: Linux Kernel Mailing List , "Linux FS Dev Mailing List" , Linux F2FS Dev Mailing List From: Jens Axboe Message-ID: <86e4eb4c-3cb8-8e0f-ebb4-48cdf4dea8e8@fb.com> Date: Wed, 27 Jul 2016 12:29:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BLUPR14CA0038.namprd14.prod.outlook.com (10.163.77.176) To DM5PR15MB1193.namprd15.prod.outlook.com (10.173.209.11) X-MS-Office365-Filtering-Correlation-Id: e601946f-d18b-4a56-ae4f-08d3b64bfa02 X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;2:fwEnr0p1kXG6XBPH0wcHQECBCnL4aRQ8HKJJ1Af7TcrxHQCSXyK+jniuyn2xwExarU6ahjBSKjkUn2MQWo1mq1SBE24LLlf5llVSMCQ1jjwp4mcYAn28BpJkqv+AugvJb/uacmctu9Xa8dYVxHYrfc77aA+7DwsaxHizyjEUksJTlkLiqXNJ4jzSjeRq3IDW;3:LnLK6USCtf2H9TiQoSF6UypCp6U7R9Mzm40+tpp87v1e01fws7i0N0MYW0OtkBYlgjI9K9qpE1kAnO6j9yXhKYVWEexilVOWmEjkM0fcHFe6QJ4IaZR5THMQQ/lBZHeC;25:XvlwTIBLmps+LIi1Cft4zzMZ6jILScmDkaPaOIpiLY8z5AQ56P4UCbCPOxyAzzHnrIzS0MrDQ3AS/FBjekCQ4Bb/DPkUAa8cxwpZNEWH0G7ZSgPiHwYiJbKXnnFrfyb1ZcIo9D8DDdr9KGdoOBXfI5WrdCpa1lu0JnBc9IgzBlXzhnVqwJ0KdpuRx1PzttuVOENffUKuGr4DG93vX3ygs40AtGb1pYBVohFfiIADVoPnQAZfUlrcZTNycqitoRXzDy2lD95GvrFeu4AVRRs4hOqD5/iVOcwOFZv4IjQSy5IEB0opwAl4y06ShUD+JV2/WDWEgCUUqIsMDDESmp+yVQXhQgDck5glGeJiLpfQc+vuTnQIIKiRz83Q33BmULOA7lyD79a5syKnSO8D2Nh1kz2+MOhKcu5uMemk4pvRxWg=;31:ZdHhAtrA5KE370uDLJa9L7wZ8c+53BRB17FghYg+e75E3AmFPLfRPdBjdCCKg3EdzRfb29tdCIBmRYg5kKS0jRTwJGBqdPTnht3onS5Yn+puQPU4zFjeMICIvI5mqEENgc/Nd7pz8czSoPDI7/RSnepjm5xZBCHuV04NLwcVCedK+4OzdfkEgyw5+uwjcjQdFhfFDCzyHaUybfPS2u0CIw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1193; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;20:SVV25nzanSM9HCD/cWOBA8+nKNxpeVVOiXYdpVk1FUQpnMhO8XWz1Fjlr4EKdp8ux49r2Xu5ry4vMKpC68j9CD4tG62ku90rKRPn4AhnJf0D0gONdvHFNOkT6wz13//RJHK8/73+nSW6lbFy3lXUKiX5xkuaEte1dH7a2NseTig=;4:w8sE0GqJDU2FksD+ywdGulKI6iksrmx9Kp+Bdj6TiYh7bOQBK4qF+Xm57j4IlyjAObpWpB5rIlidlIFropHzjMlqCKFbIofBhLY6wnf4A2CEcGQFM5XC8QlVThPT4YO2P/LBqcG4V2Iz8Yx7AkXV2JvDATwjCsxvI5THQvI7DA9r7raLp/OAY+QpLdJvTquX3BtqAoB1pc7g/wSU40Wb4XDGhbOgaw/DCESPmexX0mMd/uRAxMCRCKNXPg3f2+7HzS/ir+VoeMaIqRfh3mGS1R62bnbVOTC9MzgHiWRVC4yLfJorAPxyGNpz17MbYEHke0zxblcJ7JY8vZPCofIDapsuXin5HO/SqDlZgPHLX/Qe4KAuPsapbS3gL1NEkboHYAVSa6Dtdi+n5/STHPazxLQfWfxNuYkmhp3YVisqNXw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(84791874153150); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:DM5PR15MB1193;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1193; X-Forefront-PRVS: 0016DEFF96 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(24454002)(199003)(377454003)(189002)(230700001)(4326007)(64126003)(3846002)(92566002)(76176999)(117156001)(19580405001)(586003)(19580395003)(50466002)(23676002)(54356999)(83506001)(6116002)(31696002)(36756003)(47776003)(31686004)(50986999)(101416001)(2906002)(65956001)(65806001)(33646002)(66066001)(5001770100001)(4001350100001)(42186005)(106356001)(97736004)(105586002)(7736002)(68736007)(86362001)(7846002)(189998001)(305945005)(8676002)(81156014)(2950100001)(77096005)(81166006)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1193;H:[192.168.1.130];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxMTkzOzIzOlRqdUE1bm5hcC9wK3paREprcldTUDVMQnUw?= =?utf-8?B?U3djdXNYM3lIWjZyZ0ozR0U5SGIxRUxGVTdMOUd2Sktla3RxckNhODJLRVI3?= =?utf-8?B?WmFpakw5Rk9CVzY3cWNpeGd1TGFDY0pKRlJxeldtWmNtZm5sai8wVjF4SFdG?= =?utf-8?B?Z3hqVDd1T0c3Ri9USHhyYUdLTE5BLzREaVFhUlh0emxqRjhsY29aRlk5bEdr?= =?utf-8?B?YVNlVjNNZDFwcjRicmxMWnlTV3FpdVJ4NHRzdHRmcDhJT1NySUY5NVdCWVhS?= =?utf-8?B?SUVDNGp0OEg5eXRRVSs0TjhCNVdYWU1iT09XcHl5MFl3anp0UUlXUnVha0Uz?= =?utf-8?B?YmVDRm9mN00xNm85VHZLY25nTnFiM2RyNk9hRVpYZTVVTEU4VTZYbndYRWhm?= =?utf-8?B?SnBsZERMMS93OFFVaDhwMm9sTjQyMTNUaVdOM3RrWlloSTJYZ01senkwZ2Zy?= =?utf-8?B?RXZrT0lGZzVPK0EwS1hOR1ZuVE5kMGw1b001Mks4M2E4Nm9tNldXendJNDFa?= =?utf-8?B?ZjhIalF0ZGVWS3ZuYnNtRHRYaUhjTFU4MEd2SDMxSk1vVXR6SlBuUnAwUlFw?= =?utf-8?B?Zmx4VlU4Zm14bHl5MkRmbGl6VmszeVp1Uy9CNll2bEpHM0UvWm9LUVViMzU1?= =?utf-8?B?ZEVpTUY3SFRTaWE4VTRmc1dBbStIS0Y2VE5zTDBwQisydlFhWW11Uk9ubnJ5?= =?utf-8?B?NmdYT2JFZHM0RG9RZTlCcTlvOVFDQXBSZk9tQXhjTDRFL24vQVJvOGhpRk9K?= =?utf-8?B?VmVkeGFVWVZlSUsvdWVWY1pYRStpdUJQbjZaNno0dk9TUEkwckFpajFrZjEy?= =?utf-8?B?Ri9FRVYyRGQzdjQyQ1lEOVlMNFZDdkFRM2NxZWtwQzdlK3B0N3djL2c4NWFt?= =?utf-8?B?K3dQbHNJKzYyR0p6ZzVhY3RZc0NoZmQ0WVczckdFaFdjbWZjVDcxeXNyZ1Q2?= =?utf-8?B?ZS9xVXprY1JhNlRtSmg1R0VvUUp6ZEZXVFZreVdnMHJDYWFtVXViVjFWR3VW?= =?utf-8?B?TVM2YmVEdTNjclk3UjR2eFZZKzRJLzR3ejlpNi9ROXpxM2hYZU85Zy9Ed1hs?= =?utf-8?B?S0pkZ1c2N2dGTnpMcFkwTHFHWi9XdVdJOEtUN0tVemI5V0RkWjVGOVdHWkg1?= =?utf-8?B?TXAzNlB6dXJMWVdySXJxajJuemdHRnN5TnJTUnVEQlk1K1p1QzdKbDU2L2hx?= =?utf-8?B?NlFHRnJndlYzV1RRRG01citHeGVWbCs1TzhQb1FiMU1KaXMxK0tnUDd5SHBF?= =?utf-8?B?Wnc5bjJTeWFMWFZxQ21BV2xvZHIzemxXc3dPYk8rNUdyU0JPeXhXK3BZVDVB?= =?utf-8?B?VXk1bzkzK1F0Zy8rZk1hMzdqckdTWGFQaXhqUEphcGZyZjFjMHdneEJEaWo3?= =?utf-8?B?Q2wvQ3RwalNkdW44UGNmQ2R5NFN0VmNLVUkvQzZTaksvUElOSFNDU0U5WFdv?= =?utf-8?B?NWcwTEQ3U2s1SHd2N3VydjB1dFBTQlh4SkF1UGx3TE5ZK1RIdjk5RDVDS3Jh?= =?utf-8?B?R3M1LzRJZnVtZ3JJaWVXUjJJTFZJTnpUMno4L2cveHFDRXcrZ1pqZC9tQlZG?= =?utf-8?B?bnBhVHZDaWZyUVRQenZVVXJ3RmJhSG90c1E1UWZDL2MvTFBYTWhPQWxmQzlG?= =?utf-8?B?bmpQRzdqdmdVQTYzeGhnTEhJYkVycVVEbjlSTVBNd29QWEQ3aEMwSEtjS3kr?= =?utf-8?B?YnVhK2pVWUF2QTE2MlZ3UmVOMnl4R3hmVXRqWTJKU0hUUThHK0p2b1hBZlh2?= =?utf-8?B?Y0wxdUxGMXk2TUUvZVZUdz09?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;6:+QkcpzLczQeDUDQzK6QiP8QKh2k3CCyoeuO2ffPfQsfQ9oJrc9YBWg3nSPU4HaEb+XHa+KLGwBVeTa3wxjK+trfJ0fiy04KqDM8xCH+R1yBx4zU/pz+kb9EgQ2BijB03LlhKfRyNGrSv9AfX/3hRRhmePLUTcSvV7Xyp1cJt/yLW6LNZ1wQqE0WcsVy/UmZ2MJMedg427seZlYIyVlTmMHkBnVwIUL1jCc8SBMpyaxdljWuZzaS30t1kZm65DQ/ry0IJtzbA5DYDA+/gLO8UIayhjlsxforMSC6uvnanZLg=;5:B4nXdkWKu05uXEWuVu58jxh9JsuSNcOKJM2r7866aTGVNWuJpei8g0SlaPWOWl5iRWOLeF7roJjHzLp2JcmJcbIz0wmpEz6E4H9rpGoZ1VdKtS6sajjg+nwibLFrkKQSd3GQrxR7kH+It0Zfr4XIMA==;24:C8VhxoVjJvJvhhyCvUMVOroshCCuJ+HNShU6nPbR9ngCAKRpia6X2TX060D59fMb+F8lTqolBxW3KqDu2Lk4blk3mMc7RQlFIM4pL9eVvog=;7:jPlv16i5htmLBokuzM4hRdnBZ0lL2yJF5KtUZTaredjT/LaKOuNns4qyXQQp+kkSHHeNowwaIcfeZn06qzE5EvBTr4vml5cvlkEegG6CeybA0eVJ5LCNwr54u571VfmlJ+Tmh0YTlXOAPNqvZ7XgfC2BcUWL9g/qmSty5gsN7CikiUyCUQoDP7vfKXRgxyCKP2H/uhKW8f/n18yZyuzD6Za8FQZJ7lLBNYEZTVR0nAWHWCvdKXEuNgd5RnJMy4gn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;20:WJC79Su+F/rYA4woTxNbOFoeqFy5qOkEgwdihfV1DkUK1ABubmAa0/onb5kjKMZXZyGkGirs2Ib2jicfEcK72ZOMfBuucWNtxeOBhIH9w57fDD0gyOuH/am1cFnnsp7PQxjsK5LApjCIui74Q20Lfnp+WbKPW0ogk95HpSO/mAk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 18:29:41.3826 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1193 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-27_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/2016 11:46 AM, Linus Torvalds wrote: > On Tue, Jul 26, 2016 at 9:08 PM, Jaegeuk Kim wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git tags/for-f2fs-4.8 > > This got some merge conflicts with the bio interface rework > (bio_set_op_attrs() etc), and while I tried to fix it up, I don't have > any sane way to test the end result, so I might have screwed up > royally. > > My resolution looks sane to me, and compiles, but that's all I'm > really going to guarantee. Can you please give it a good round of > testing, and Jens, can you check it out too. In particular, the > fs/f2fs/data.c changes is what I might have screwed up.. Looks OK to me, though I think you could have dropped the ->bi_rw assignment in f2fs_submit_page_bio(): bio->bi_rw = fio->op_flags; bio_set_op_attrs(bio, fio->op, fio->op_flags); __submit_bio(fio->sbi, bio, fio->type); -- Jens Axboe