From: Andrew Lunn <andrew@lunn.ch>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [PATCH net-next v8 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988
Date: Sat, 22 Jun 2024 19:57:44 +0200 [thread overview]
Message-ID: <86e5c28a-42dd-432b-8bd7-2ccc4567520f@lunn.ch> (raw)
In-Reply-To: <20240621122045.30732-12-SkyLake.Huang@mediatek.com>
On Fri, Jun 21, 2024 at 08:20:43PM +0800, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@mediatek.com>
>
> Add support for internal 2.5Gphy on MT7988. This driver will load
> necessary firmware, add appropriate time delay and figure out LED.
> Also, certain control registers will be set to fix link-up issues.
>
> Signed-off-by: SkyLake.Huang <skylake.huang@mediatek.com>
> ---
> Changes in v8:
> - Replace tr_modify with mtk_tr_modify and fix alignment.
> - Remove unnecessary outer parens of "supported_triggers" var.
> - Align declarations in mtk_2p5gephy_driver[]. At first, some of them are
> ".foo<tab>= method_foo", and others are ".bar<space>= method_bar".
> Use space instead for all of them here.
> ---
> MAINTAINERS | 1 +
> drivers/net/phy/mediatek/Kconfig | 11 +
> drivers/net/phy/mediatek/Makefile | 1 +
> drivers/net/phy/mediatek/mtk-2p5ge.c | 435 +++++++++++++++++++++++++++
> 4 files changed, 448 insertions(+)
> create mode 100644 drivers/net/phy/mediatek/mtk-2p5ge.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e58e05c..fe380f2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13793,6 +13793,7 @@ M: Qingfang Deng <dqfext@gmail.com>
> M: SkyLake Huang <SkyLake.Huang@mediatek.com>
> L: netdev@vger.kernel.org
> S: Maintained
> +F: drivers/net/phy/mediatek/mtk-2p5ge.c
> F: drivers/net/phy/mediatek/mtk-ge-soc.c
> F: drivers/net/phy/mediatek/mtk-phy-lib.c
> F: drivers/net/phy/mediatek/mtk-ge.c
> diff --git a/drivers/net/phy/mediatek/Kconfig b/drivers/net/phy/mediatek/Kconfig
> index 448bc20..1490352 100644
> --- a/drivers/net/phy/mediatek/Kconfig
> +++ b/drivers/net/phy/mediatek/Kconfig
> @@ -25,3 +25,14 @@ config MEDIATEK_GE_SOC_PHY
> the MT7981 and MT7988 SoCs. These PHYs need calibration data
> present in the SoCs efuse and will dynamically calibrate VCM
> (common-mode voltage) during startup.
> +
> +config MEDIATEK_2P5GE_PHY
> + tristate "MediaTek 2.5Gb Ethernet PHYs"
> + depends on (ARM64 && ARCH_MEDIATEK) || COMPILE_TEST
> + select MTK_NET_PHYLIB
> + help
> + Supports MediaTek SoC built-in 2.5Gb Ethernet PHYs.
> +
> + This will load necessary firmware and add appropriate time delay.
> + Accelerate this procedure through internal pbus instead of MDIO
> + bus. Certain link-up issues will also be fixed here.
> diff --git a/drivers/net/phy/mediatek/Makefile b/drivers/net/phy/mediatek/Makefile
> index 814879d..c6db8ab 100644
> --- a/drivers/net/phy/mediatek/Makefile
> +++ b/drivers/net/phy/mediatek/Makefile
> @@ -2,3 +2,4 @@
> obj-$(CONFIG_MTK_NET_PHYLIB) += mtk-phy-lib.o
> obj-$(CONFIG_MEDIATEK_GE_PHY) += mtk-ge.o
> obj-$(CONFIG_MEDIATEK_GE_SOC_PHY) += mtk-ge-soc.o
> +obj-$(CONFIG_MEDIATEK_2P5GE_PHY) += mtk-2p5ge.o
> diff --git a/drivers/net/phy/mediatek/mtk-2p5ge.c b/drivers/net/phy/mediatek/mtk-2p5ge.c
> new file mode 100644
> index 0000000..f3efcc4
> --- /dev/null
> +++ b/drivers/net/phy/mediatek/mtk-2p5ge.c
> @@ -0,0 +1,435 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +#include <linux/bitfield.h>
> +#include <linux/firmware.h>
> +#include <linux/module.h>
> +#include <linux/nvmem-consumer.h>
> +#include <linux/of_address.h>
> +#include <linux/of_platform.h>
> +#include <linux/pinctrl/consumer.h>
> +#include <linux/phy.h>
> +#include <linux/pm_domain.h>
> +#include <linux/pm_runtime.h>
> +
> +#include "mtk.h"
> +
> +#define MTK_2P5GPHY_ID_MT7988 (0x00339c11)
> +
> +#define MT7988_2P5GE_PMB "mediatek/mt7988/i2p5ge-phy-pmb.bin"
You probably want a MODULE_FIRMWARE() so the firmware gets placed into
the initrd.
> +#define BASE100T_STATUS_EXTEND (0x10)
> +#define BASE1000T_STATUS_EXTEND (0x11)
> +#define EXTEND_CTRL_AND_STATUS (0x16)
These don't appear to be used.
Andrew
next prev parent reply other threads:[~2024-06-22 17:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 12:20 [PATCH net-next v8 00/13] net: phy: mediatek: Introduce mtk-phy-lib and add 2.5Gphy support Sky Huang
2024-06-21 12:20 ` [PATCH net-next v8 01/13] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers Sky Huang
2024-06-22 17:12 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 02/13] net: phy: mediatek: Fix spelling errors and rearrange variables Sky Huang
2024-06-22 17:13 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 03/13] net: phy: mediatek: Move LED helper functions into mtk phy lib Sky Huang
2024-06-22 17:16 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 04/13] net: phy: mediatek: Improve readability of mtk-phy-lib.c's mtk_phy_led_hw_ctrl_set() Sky Huang
2024-06-22 17:17 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 05/13] net: phy: mediatek: Integrate read/write page helper functions Sky Huang
2024-06-22 17:20 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 06/13] net: phy: mediatek: Hook LED helper functions in mtk-ge.c Sky Huang
2024-06-22 17:29 ` Andrew Lunn
2024-06-22 21:03 ` Daniel Golle
2024-06-24 10:38 ` SkyLake Huang (黃啟澤)
2024-06-21 12:20 ` [PATCH net-next v8 07/13] net: phy: mediatek: add MT7530 & MT7531's PHY ID macros Sky Huang
2024-06-22 17:32 ` Andrew Lunn
2024-06-24 10:39 ` SkyLake Huang (黃啟澤)
2024-06-21 12:20 ` [PATCH net-next v8 08/13] net: phy: mediatek: Change mtk-ge-soc.c line wrapping Sky Huang
2024-06-22 17:34 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 09/13] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2024-06-22 17:41 ` Andrew Lunn
2024-06-24 10:41 ` SkyLake Huang (黃啟澤)
2024-06-21 12:20 ` [PATCH net-next v8 10/13] net: phy: mediatek: Extend 1G TX/RX link pulse time Sky Huang
2024-06-22 17:46 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2024-06-22 17:57 ` Andrew Lunn [this message]
2024-06-24 10:46 ` SkyLake Huang (黃啟澤)
2024-06-21 12:20 ` [PATCH net-next v8 12/13] net: phy: mediatek: Fix alignment in callback functions' hook Sky Huang
2024-06-22 18:30 ` Andrew Lunn
2024-06-21 12:20 ` [PATCH net-next v8 13/13] net: phy: mediatek: Remove unnecessary outer parens of "supported_triggers" var Sky Huang
2024-06-22 18:31 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e5c28a-42dd-432b-8bd7-2ccc4567520f@lunn.ch \
--to=andrew@lunn.ch \
--cc=SkyLake.Huang@mediatek.com \
--cc=Steven.Liu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®