From: Ray Jui <ray.jui@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org
Cc: grygorii.strashko@ti.com, simon.horman@netronome.com,
robh+dt@kernel.org, rafal@milecki.pl, davem@davemloft.net,
andrew@lunn.ch, mark.rutland@arm.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Eric Anholt <eric@anholt.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells
Date: Fri, 6 Dec 2019 16:54:22 -0800 [thread overview]
Message-ID: <86e8fbec-f9e5-28d8-cc58-c12ce53a18e9@broadcom.com> (raw)
In-Reply-To: <20191206181909.10962-1-f.fainelli@gmail.com>
On 12/6/19 10:19 AM, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
> mdio: mdio@18002000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18002000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> status = "disabled";
>
> gphy0: ethernet-phy@0 {
>
Looks good! Thanks!
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
next prev parent reply other threads:[~2019-12-07 0:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 18:19 Florian Fainelli
2019-12-07 0:54 ` Ray Jui [this message]
2019-12-07 17:13 ` Simon Horman
2019-12-09 18:14 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e8fbec-f9e5-28d8-cc58-c12ce53a18e9@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®