From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Michael Klein <michael@fossekall.de>,
Daniel Golle <daniel@makrotopia.org>,
Aleksander Jan Bajkowski <olek2@wp.pl>,
Bevan Weiss <bevan.weiss@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 4/4] net: phy: realtek: get rid of magic number in rtlgen_read_status()
Date: Sun, 4 Jan 2026 13:12:24 +0000 [thread overview]
Message-ID: <86e976322ee9bf1612eadf4403158a837a0ee076.1767531485.git.daniel@makrotopia.org> (raw)
In-Reply-To: <cover.1767531485.git.daniel@makrotopia.org>
Use newly introduced helper macros RTL822X_VND2_TO_PAGE and
RTL822X_VND2_TO_PAGE_REG to access RTL_VEND2_PHYSR register over Clause-22
paged access instead of using magic numbers.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/phy/realtek/realtek_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c
index 142a5421fe84c..a61e9ed05cdd2 100644
--- a/drivers/net/phy/realtek/realtek_main.c
+++ b/drivers/net/phy/realtek/realtek_main.c
@@ -1153,7 +1153,8 @@ static int rtlgen_read_status(struct phy_device *phydev)
if (!phydev->link)
return 0;
- val = phy_read_paged(phydev, 0xa43, 0x12);
+ val = phy_read_paged(phydev, RTL822X_VND2_TO_PAGE(RTL_VND2_PHYSR),
+ RTL822X_VND2_TO_PAGE_REG(RTL_VND2_PHYSR));
if (val < 0)
return val;
--
2.52.0
prev parent reply other threads:[~2026-01-04 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 13:11 [PATCH net-next 0/4] net: phy: realtek: various improvements for 2.5GE PHYs Daniel Golle
2026-01-04 13:11 ` [PATCH net-next 1/4] net: phy: realtek: fix whitespace in struct phy_driver initializers Daniel Golle
2026-01-04 13:11 ` [PATCH net-next 2/4] net: phy: realtek: implement configuring in-band an Daniel Golle
2026-01-04 13:12 ` [PATCH net-next 3/4] net: phy: realtek: use paged access for MDIO_MMD_VEND2 in C22 mode Daniel Golle
2026-01-04 14:30 ` ALOK TIWARI
2026-01-04 21:23 ` Russell King (Oracle)
2026-01-04 22:02 ` Daniel Golle
2026-01-04 22:38 ` kernel test robot
2026-01-05 0:52 ` kernel test robot
2026-01-04 13:12 ` Daniel Golle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e976322ee9bf1612eadf4403158a837a0ee076.1767531485.git.daniel@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=bevan.weiss@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@fossekall.de \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®