From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B9E2C43142 for ; Tue, 26 Jun 2018 14:56:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D518E26CAF for ; Tue, 26 Jun 2018 14:56:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D518E26CAF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbeFZO4l (ORCPT ); Tue, 26 Jun 2018 10:56:41 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:46930 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbeFZO4j (ORCPT ); Tue, 26 Jun 2018 10:56:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9981480D; Tue, 26 Jun 2018 07:56:39 -0700 (PDT) Received: from big-swifty.misterjones.org (big-swifty.cambridge.arm.com [10.1.26.242]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 44F423F5C0; Tue, 26 Jun 2018 07:56:34 -0700 (PDT) Date: Tue, 26 Jun 2018 15:56:28 +0100 Message-ID: <86efgt7g0z.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Laurentiu Tudor Cc: , , , , Subject: Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask In-Reply-To: <20180626143712.30489-1-laurentiu.tudor@nxp.com> References: <20180626143712.30489-1-laurentiu.tudor@nxp.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jun 2018 15:37:12 +0100, Laurentiu Tudor wrote: > > Update the effective affinity mask to fix this warning issued by the > generic irq handling code: > > "genirq: irq_chip MSI did not update eff. affinity mask of irq x" > > Signed-off-by: Laurentiu Tudor > --- > drivers/irqchip/irq-ls-scfg-msi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c > index 1ec3bfe56693..d81d5b016438 100644 > --- a/drivers/irqchip/irq-ls-scfg-msi.c > +++ b/drivers/irqchip/irq-ls-scfg-msi.c > @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data, > } > > cpumask_copy(irq_data->common->affinity, mask); > + irq_data_update_effective_affinity(irq_data, mask); > > return IRQ_SET_MASK_OK; > } It has already been addressed here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=893fbfff976cd069f2e60c3b186dbe3f85504db2 Thanks, M. -- Jazz is not dead, it just smell funny.