From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B449C4167B for ; Mon, 4 Dec 2023 04:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234373AbjLDEEE (ORCPT ); Sun, 3 Dec 2023 23:04:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjLDEEC (ORCPT ); Sun, 3 Dec 2023 23:04:02 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 388A9D5; Sun, 3 Dec 2023 20:04:05 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2CE4F165C; Sun, 3 Dec 2023 20:04:51 -0800 (PST) Received: from [10.162.41.8] (a077893.blr.arm.com [10.162.41.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ACAC43F762; Sun, 3 Dec 2023 20:03:59 -0800 (PST) Message-ID: <86f91d68-207d-40a5-9d76-1cbb80e4f210@arm.com> Date: Mon, 4 Dec 2023 09:33:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V15 1/8] arm64/sysreg: Add BRBE registers and fields Content-Language: en-US To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org References: <20231201053906.1261704-1-anshuman.khandual@arm.com> <20231201053906.1261704-2-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/23 22:28, Mark Brown wrote: > On Fri, Dec 01, 2023 at 11:08:59AM +0530, Anshuman Khandual wrote: > > This looks good apart from a few small omissions: > >> +SysregFields BRBINFx_EL1 > >> +Enum 13:8 TYPE >> + 0b000000 UNCOND_DIRECT >> + 0b000001 INDIRECT >> + 0b000010 DIRECT_LINK >> + 0b000011 INDIRECT_LINK >> + 0b000101 RET >> + 0b000111 ERET >> + 0b001000 COND_DIRECT >> + 0b100001 DEBUG_HALT >> + 0b100010 CALL >> + 0b100011 TRAP >> + 0b100100 SERROR >> + 0b100110 INSN_DEBUG >> + 0b100111 DATA_DEBUG >> + 0b101010 ALIGN_FAULT >> + 0b101011 INSN_FAULT >> + 0b101100 DATA_FAULT >> + 0b101110 IRQ >> + 0b101111 FIQ >> + 0b111001 DEBUG_EXIT >> +EndEnum > > DDI0601 2023-09 also defines 0b110000 as an IMPLEMENTATION DEFINED > exception to EL3. Should this field be just IMPDEF or IMPDEF_TRAP_EL3 sounds better ? > >> +SysregFields BRBCR_ELx >> +Res0 63:24 >> +Field 23 EXCEPTION >> +Field 22 ERTN >> +Res0 21:9 > > DDI0601 2023-09 defines bit 9 as FZPSS. Sure, will update. > >> +Sysreg BRBINFINJ_EL1 2 1 9 1 0 > >> +Enum 13:8 TYPE >> + 0b000000 UNCOND_DIRECT >> + 0b000001 INDIRECT >> + 0b000010 DIRECT_LINK >> + 0b000011 INDIRECT_LINK >> + 0b000101 RET >> + 0b000111 ERET >> + 0b001000 COND_DIRECT >> + 0b100001 DEBUG_HALT >> + 0b100010 CALL >> + 0b100011 TRAP >> + 0b100100 SERROR >> + 0b100110 INSN_DEBUG >> + 0b100111 DATA_DEBUG >> + 0b101010 ALIGN_FAULT >> + 0b101011 INSN_FAULT >> + 0b101100 DATA_FAULT >> + 0b101110 IRQ >> + 0b101111 FIQ >> + 0b111001 DEBUG_EXIT >> +EndEnum > > DDI0601 2023-09 also defines 0b11000 as IMPLEMENTATION DEFINED exception > to EL3. Should this field be just IMPDEF or IMPDEF_TRAP_EL3 sounds better ? Seems like BRBINFx_EL1 could be used for defining BRBINFINJ_EL1 as well.