From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73D13A1688; Sat, 3 Oct 2026 12:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791029292; cv=none; b=igOz2ZZkg/MEH4FZyYTrX1mzkUawN/7XNHZ0VXQgcnY8C2t3wyncg9jpNwuzTEwCrWrSvzPUbMMn7ECfXPYXHh7s7Nt/IEzgwz++CX+ara+bs7Hbj/cnp7xj7wRJXlIm1F2GzdqUlkd2oN7UkDxPJETbIL3rPkRymtlEBO3eNkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791029292; c=relaxed/simple; bh=IhBfPrAhubFGdHKwhyHJrvg3ZbtbaXREftIOUfTKaG0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=M2fU6/2BxhXFjGESmiu6JJvgrEu5HtSGscjpl3h8uExUTLz8lzhtIM13XIH4wdeZkBmKYjWBMgfU7p2sWFNCD91F+b6A8RwKs8m8cSzXuB3wpAZNlvUGT7DM7woZq8erkqTBpt5ceFforFTc6LIA9QR84BqqJqUmfRyvkVsdOBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fy6TJMzQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fy6TJMzQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7DF81F0089B; Sat, 3 Oct 2026 12:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791029291; bh=2VwFiLcD3ULkC2A6L1yKWuUIxB62Ph+7Tm6gN1JBF5U=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Fy6TJMzQk4cahDfG3QAIr52g1zzmOcnK4ffVAcPCkWIXBHCmbmjcIqh5N7kmiFPrf Fez9zPcgAsM3ABHqRo9y7QnCGsIso6xt4nL4xMJ7RBTiXerjHz2NAcz3VGEN9mUeEi tk2xaRI0+akbXc71prv6dyIXJjU5HGmyuromgglbSym91H8CskF8yuV5dN4I1ha1GO 14877bmSRY0B0iZe7rEWNCZT1qYkLp70yLL4RL3543yefVuTtX6KL5z+XmHLxi6T79 XY/lM1ZER+XRgP04CJOss40EEYKRlCgwLWEE/lKVkclimeGEx16kdSrkClR1OVG6m2 QLDVTL4UGnT1Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xCyXA-0000000GWcU-3vLV; Sat, 03 Oct 2026 12:08:09 +0000 Date: Sat, 03 Oct 2026 13:08:08 +0100 Message-ID: <86h5j32dhz.wl-maz@kernel.org> From: Marc Zyngier To: Karl Mehltretter Cc: Oliver Upton , kvmarm@lists.linux.dev, Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Paolo Bonzini , Shuah Khan , Eric Auger , Christoffer Dall , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 0/4] KVM: arm64: fix VGICv3 redistributor rollback In-Reply-To: References: <20260831081005.41346-1-kmehltretter@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kmehltretter@gmail.com, oupton@kernel.org, kvmarm@lists.linux.dev, fuad.tabba@linux.dev, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, pbonzini@redhat.com, shuah@kernel.org, eric.auger@redhat.com, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 02 Oct 2026 18:45:21 +0100, Karl Mehltretter wrote: > > On Mon, Aug 31, 2026 at 10:10:00AM +0100, Karl Mehltretter wrote: > > Changes since v3: > > - Dropped the REDIST/REDIST_REGION serialization and VGIC init/destroy > > rework, keeping the fix close to v2. (Marc) > > - Limited rollback to assignments from the new region so an older-region > > assignment cannot be missed during concurrent vCPU creation. > > - Added Fuad's Reviewed-by tags to patches 1, 3 and 4. These are otherwise > > unchanged from v3 (formerly patches 1, 4 and 5). > > > > Previous version: > > v3: https://lore.kernel.org/r/20260822095346.53882-1-kmehltretter@gmail.com > > > > Karl Mehltretter (4): > > KVM: arm64: vgic-v3: Undo assignment on iodev registration failure > > KVM: arm64: vgic-v3: Roll back assignments from the new region > > KVM: arm64: selftests: Pass guest code to vm_gic_create_with_vcpus() > > KVM: arm64: selftests: Test VGICv3 redistributor region retry > > > > arch/arm64/kvm/vgic/vgic-mmio-v3.c | 54 ++++++-- > > tools/testing/selftests/kvm/arm64/vgic_init.c | 116 ++++++++++++++++-- > > 2 files changed, 151 insertions(+), 19 deletions(-) > > A friendly ping on v4. Patches 1, 3, and 4 have Fuad's Reviewed-by; > patch 2 was revised following Marc's feedback. The trouble is that we don't seem to agree on what "minimal changes" means. I've applied these patches locally, and simplified the first two patches to get rid of the superfluous helpers. Thanks, M. -- Without deviation from the norm, progress is not possible.