From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC6B142AFB7; Wed, 12 Aug 2026 14:45:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786545937; cv=none; b=hprjMbByWnZZ2nkLfHdI3cjg/ofbbkbtkwjtqriYUCfdOJ+l9FyJ8u+E/rt8pziIDNgfr16dYnRjpa1rkq4Bd/HHb4tlVI8431/Nn8Vj/BHTEtDyPknQqcSvQhBLTPjOt/0liiO6zmrJUoD68a/VMZOdp+MDLCxkPXDFi6U0H/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786545937; c=relaxed/simple; bh=NTt6XuQCIdW9JqzPhjnzJ2cSiGZnTtzcKnBNpeNrVqQ=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=VRpTmHBaMNE53BrhGErQ2uui7MerfdZKf+8e6nd+eWAX7ngLUuiLsmpF12+aUqdq1STa77xkJeWb8CKHeshbsM2BtGY0iWW5/mvnG854ebiSVl+aKqZELZhnWs82GLgs59cbLZBtEqo1dLdqyDBubtZKkN6hNyE/oslFgAHJqc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OQSmYCYe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OQSmYCYe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76EC81F000E9; Wed, 12 Aug 2026 14:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786545935; bh=ItXHwCR4UWoF+igD+cDz15jgqe0Ig5RlQA7lP5b3bLQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=OQSmYCYehQ6ZN6Blgyq9sQtPmZ6bVHugKUvV7ANM7DbiMG2p8tzn+I5SuulKF+Y1T RQpfZBOXkQyJzVPonepamFw1Wb6t3Gn/VzPLvhBhoJw4qxwNfQX+GFrS20augdNDmB +C2hwXAmSAv2eDGQ77kOqgGUVrPpHW5rOzdKkb00MsWzSgtBbchQ/62th4o7fBCs8u oB13BKwUPqY7a/Gy/FsVVB96NjI6mzbfGDGCoVyXw+feW3re0pp7MU0v24TNSi3/9D z4utoMxIZdHjEh1yOuW81EtAA4kNq44DsYj1iVHzT2qTO/3v3eOCx1Iif9+WxUUHmo A5rPTWxgP8iow== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wuACz-0000000EyOP-0InF; Wed, 12 Aug 2026 14:45:33 +0000 Date: Wed, 12 Aug 2026 15:45:32 +0100 Message-ID: <86h5kz1joz.wl-maz@kernel.org> From: Marc Zyngier To: Karl Mehltretter Cc: Oliver Upton , kvmarm@lists.linux.dev, Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Paolo Bonzini , Shuah Khan , Eric Auger , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH 2/2] KVM: arm64: selftests: Test VGICv3 redistributor region retry In-Reply-To: <1cf282aec3fff31e89bdb98f636b7027afcf129a.1786344511.git.kmehltretter@gmail.com> References: <1cf282aec3fff31e89bdb98f636b7027afcf129a.1786344511.git.kmehltretter@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kmehltretter@gmail.com, oupton@kernel.org, kvmarm@lists.linux.dev, fuad.tabba@linux.dev, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, pbonzini@redhat.com, shuah@kernel.org, eric.auger@redhat.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 10 Aug 2026 07:52:17 +0100, Karl Mehltretter wrote: > > The existing redistributor-region test already adds valid partial > regions, rejects a later region that collides with the distributor, and > retries with a valid region. Its guest code does not access a > redistributor, so it misses redistributor MMIO bus entries lost by the > failed rollback. > > Run a guest that reads GICR_TYPER from the second redistributor in the > original region and verifies its processor number. Put the test layout What does test layout mean here? > outside the default guest memory slot so an absent iodev results in a > KVM_EXIT_MMIO instead of an ordinary RAM access. I really hope that accessing an iodev *never* results in RAM access. That'd be... unproductive, at the very least. > > Allow the common VGIC setup helper to select the guest entry point so the > retry case can reuse the normal test setup. [...] This really need to be split. One patch to change the testing infrastructure, another one for whatever new test you want to add. Thanks, M. -- Without deviation from the norm, progress is not possible.