From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF6EC31E51 for ; Tue, 18 Jun 2019 07:49:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A21B02084D for ; Tue, 18 Jun 2019 07:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728954AbfFRHtO (ORCPT ); Tue, 18 Jun 2019 03:49:14 -0400 Received: from foss.arm.com ([217.140.110.172]:55246 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfFRHtN (ORCPT ); Tue, 18 Jun 2019 03:49:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3FD328; Tue, 18 Jun 2019 00:49:12 -0700 (PDT) Received: from big-swifty.misterjones.org (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86EF23F246; Tue, 18 Jun 2019 00:49:11 -0700 (PDT) Date: Tue, 18 Jun 2019 08:48:56 +0100 Message-ID: <86h88npc47.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Kefeng Wang Cc: Thomas Gleixner , Jason Cooper , , Subject: Re: [PATCH] irqchip/mbigen: stop printing kernel addresses In-Reply-To: <20190618032202.11087-1-wangkefeng.wang@huawei.com> References: <20190618032202.11087-1-wangkefeng.wang@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kefeng, On Tue, 18 Jun 2019 04:22:02 +0100, Kefeng Wang wrote: > > After commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), > it will print "____ptrval____" instead of actual addresses when mbigen > create domain fails, > > Hisilicon MBIGEN-V2 HISI0152:00: Failed to create mbi-gen@(____ptrval____) irqdomain > Hisilicon MBIGEN-V2: probe of HISI0152:00 failed with error -12 > > Instead of changing the print to "%px", and leaking kernel addresses, > just remove the print completely. > > Signed-off-by: Kefeng Wang > --- > drivers/irqchip/irq-mbigen.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c > index 98b6e1d4b1a6..d0cf596c801b 100644 > --- a/drivers/irqchip/irq-mbigen.c > +++ b/drivers/irqchip/irq-mbigen.c > @@ -355,8 +355,7 @@ static int mbigen_device_probe(struct platform_device *pdev) > err = -EINVAL; > > if (err) { > - dev_err(&pdev->dev, "Failed to create mbi-gen@%p irqdomain", > - mgn_chip->base); > + dev_err(&pdev->dev, "Failed to create mbi-gen irqdomain"); The alternative would be to print res as a resource, which would still help identifying the offending device by printing its physical layout, and still not reveal much. Just let me know what you prefer. Thanks, M. > return err; > } > > -- > 2.20.1 > -- Jazz is not dead, it just smells funny.