From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D77C386541; Sat, 3 Oct 2026 08:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791016720; cv=none; b=X+0g2J3RF0SIdVkosYolep7LVnVOSdWj5HMfn2o5jmSr6MLK8xj+Zc+mLLP2VS/KSHVBZhFTFXq0cdnzcSqvjv//Pa+KT7uL4qSKdiVDnFLBvFXosr+oxvss6Y59vDi8LAyo4a64cBJ30ssNwmtxnMe8SO9AZVtscx+u6lOYt84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791016720; c=relaxed/simple; bh=62jLo/IJbBFif/mdDraKU9ZKT3lc3S1g4mwDphqDaP8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=gllDjZol0inyuIKjzJJLmiIr0EYWDzeAEKRBHO3U/Yj7qWNdvBR7hiHc7D8q0EYnLPvUoph0gNt/qqxv58EE+zRpOHKZNrEdZjFCkToH+Ui5fKmDSILjvyUvN5eBObyqFn93wiOVO+I2VZOYBoNO1ABSiCmAHsB7xqmsfiQCEuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gyxFQhDi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gyxFQhDi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44E521F0089B; Sat, 3 Oct 2026 08:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791016719; bh=H5rQCXZ1gWzInXM1iaG1BbgIiBJJUiKoxe2QRaI+VTU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=gyxFQhDiIye3MnJrmNpZ2DNYijsqPdiuff1+lUxTweMxeKyOIMT4BX/1ZnCHmKUXJ HY7QZB6EiJ1aJjh0GU16c0uZ/+vdCpmcZ0AI8pki98puQ1v0Gry0DU1VVuOxKb8PPJ mfst+2NpNxiRiVg3SAHL5eACHlTgw5sWWxq8TejmCrfWeMydIzjOUyUEhtdq6t58ZI PFEqk/NMd5bDJlbGJW0jBv7TZfsfGelS7kCnaEbWDprAqr1km78jbAadTkB6SQraMs kqG46lNPijho4EwohJYNa7OB/jnn7+X7vspFFSlK2Jrcme/gmXgt91IhdfQc7gSejG KHVnpIlw9lHOA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xCvGO-0000000GUPh-2RdD; Sat, 03 Oct 2026 08:38:36 +0000 Date: Sat, 03 Oct 2026 09:38:36 +0100 Message-ID: <86ld8f2n77.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, steven.price@arm.com, vdonnefort@google.com, qperret@google.com, Fuad Tabba Subject: Re: [PATCH v4 00/18] KVM: arm64: Confine protected VM vCPU state to EL2 In-Reply-To: <20261003065713.3872839-1-fuad.tabba@linux.dev> References: <20261001135711.1640520-1-fuad.tabba@linux.dev> <179095643711.351883.2924159912626438826.b4-ty@b4> <20261003065713.3872839-1-fuad.tabba@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, steven.price@arm.com, vdonnefort@google.com, qperret@google.com, tabba@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 03 Oct 2026 07:57:13 +0100, Fuad Tabba wrote: > > Hi Marc, > > On Fri, 02 Oct 2026 16:55:26 +0100, Marc Zyngier wrote: > > [...] > > > Given how busy this merge window is, there were plenty of conflicts, most > > of them with your own patches. Please have a look at the way I resolved > > them and let me know if anything is on the bogus side of wrong... > > Thanks for taking these, and for sorting out the conflicts. Most of the > resolution matches mine, but two things in the pkvm-state merge are off: > > - In __kvm_vcpu_run(), the !host_vcpu and SVCR bail-outs still return > -EINVAL. Patch 10 changed them to ARM_EXCEPTION_IL, since the host > reads bit 31 of -EINVAL as a pending SError. > > - In __kvm_adjust_pc(), the pin path uses kern_hyp_va() on the __kern > pointer, which sparse flags. It needs kern_hyp_va_host(). > > The diff below fixes both. It also drops the set_bit()s in > pkvm_init_features_from_host() that kvm_pkvm_vcpu_allowed_features() > already does, and realigns the esr_dabt_is_cm() line. Could you fold it > into the merge resolution? > > With it applied on next, I booted protected and non-protected guests, > ran CPU hotplug in both, and ran the pKVM selftest (from my tree), all > passing. Thanks for having a look at it. I've now applied the new resolution and pushed out the updated branch, Cheers, M. -- Without deviation from the norm, progress is not possible.