From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB7133A6F00 for ; Fri, 4 Sep 2026 07:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788507590; cv=none; b=EaX2J9ctwkGByUO+AS+r66q4qD7p+Mp5PhytQGcme0X2lqhsqUDyKZPT+Thq9wsGI+FEKkCsdVoPdM+F4vorkvxtxRI0/JZFDBRm0ngtAhmb4rI9NE5w1v6MR0hxKJzCzNxkxZq3FezB8TbA5jgj9APzeJsb5zbKo5Vll1t7CTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788507590; c=relaxed/simple; bh=wtp34HzZ/w6MtCO4bvEUV/26F5ywKPfcm7mmSmEMwlE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ih7OhfvaIhE/8tV4l73IFN3iHXQvcbbCiK0aYqW5hyEyCa/LpPBVUsdv4sLwdUYAbc4ScyUbNacEPgfpDUx5oFYDP7aKWSKShtLKWelqIekossF0dUsrUBFEesOX/7DFLBpS08AKDN15lXLxUNLhUj246YWjLit6OllLcPtC0rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TZ0Bj+HJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TZ0Bj+HJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B021B1F00A3D; Fri, 4 Sep 2026 07:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788507589; bh=yLqpYDkV7tEDFi1t5AdTF7wzKnvFLphitDHQQVK47uM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=TZ0Bj+HJQULHZWAGNu23D46FAX/zQkJrKj/98YwyCCpKhkDYmmyHpePGN9s/3Nu+q 21N3Oftz9rSmrp1eq/G1R/yX30BDhOj0ClfI50XhbxFejDWXxue4NKXbIVW/XgCPvO 0YsNToy6lKfsOWZrF1654/buRtk0fWq3JYps7oWf+Jkmnc64WJ90H4OB77gRbr46Gx jL4bPTxaxkgJjrusk6EWnLMEMh0yRaQZ0Z0SzbAOV3xAD8w3qyw3phsxOzLgIPVWcX rT2J7HnsCA8q7zV0HbIWawOVThhV7L9mE5lJH9hOaFUzg7gm634QzmE1k4Cd9rVQO9 0pRD8x+54iLxA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x2OWZ-00000004hLu-20xL; Fri, 04 Sep 2026 07:39:47 +0000 Date: Fri, 04 Sep 2026 08:39:47 +0100 Message-ID: <86mrtx4g8s.wl-maz@kernel.org> From: Marc Zyngier To: Jiangshan Yi Cc: lpieralisi@kernel.org, tglx@kernel.org, radu@rendec.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 13667453960@163.com Subject: Re: [PATCH v2] irqchip/gic-v5: Install root IRQ handler last in gicv5_init_common() In-Reply-To: <20260903104014.587068-1-yijiangshan@kylinos.cn> References: <20260903104014.587068-1-yijiangshan@kylinos.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yijiangshan@kylinos.cn, lpieralisi@kernel.org, tglx@kernel.org, radu@rendec.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 13667453960@163.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 03 Sep 2026 11:40:14 +0100, Jiangshan Yi wrote: > > set_handle_irq() cannot be undone: once a handler is installed, any > further call returns -EBUSY, so the set_handle_irq(NULL) in the error > path has never worked. Drop it, and install the root handler only > after gicv5_irs_enable() has succeeded. > > set_handle_irq() only fails if another root handler is already > installed, which cannot happen on a GICv5 system. Should it ever > fail, the system is unusable: panic instead of unwinding. Note that the system is dead either way, as it isn't like someone is going to provide a replacement interrupt controller when GICv5 fails. So any error in this function is pretty fatal for the whole system. That said, this is still a reasonable cleanup. > > Link: https://lore.kernel.org/r/87fqzrmywu.wl-maz@kernel.org > Signed-off-by: Jiangshan Yi Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.