From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F1A7341061 for ; Thu, 4 Dec 2025 13:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855247; cv=none; b=QtWtx0ZgsqDPvSLmzjGYgYXDQcdX/CP7m4IormUF17QEchF43Ruetf3wzYMSKvqCTBcRAr354Omcxiy8Jw4ArdTFyN/mYRxKKlQaR2KuHkOA0kRfj+RvaNDM7ZxnSRnYB9ybKy8ng2xIroaswi9bRfUpN8WwMAbrMNxKGlRu3hQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855247; c=relaxed/simple; bh=Lj25H6jCgokXTJy4WrsUG5umeuYrwquhju3RT34kAyo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=APdpn8+Dnxw7yve55Y8aEak9YP+M+T6CzDV/zomx1FYpcfvVrkTUEk1UQ/gHXiGKAVHl01Pg4ct+f5sbCXygsKqMaT+6EfMUtVzOOP3JCoZipsKd/PbZxW4Dr3K9XjtOrT0G6quhzSgNoByy/PjSJZ4IiszZVh2nNLCCuBpECgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tlhw2Krm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tlhw2Krm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11E59C4CEFB; Thu, 4 Dec 2025 13:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764855246; bh=Lj25H6jCgokXTJy4WrsUG5umeuYrwquhju3RT34kAyo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Tlhw2KrmSin2tEXioAG8hYKGfmommZ1ZKl0H1+L4rHr2n5Qnag2wR38OQ+QSNyYsn bPlZypHtUtiaRtAT1Eqn7T6hf2SKKyD3r887vh/i4YapHs9v/kiAMCdlx6yBG/9gl/ yqUWPjNLr2yI9zbP6kwsrhGpUQ/jCFxfItxe9MqZNYkeW1KAalXf2WdLIJ69vKSnof k/ZK5bier8U5k0Wk2LbwHrlqs0+fYrw6gja5cjzIGhtpMuL+BPEJZOV+p4aGkjm+oV SHnpz67HdZJtDa23I+8obx7rQMoHvaaoyfL4TDXqZ3xGTZwfpjMFpy0lCbw5e2MnTl +MMfZqXe2hScw== From: Pratyush Yadav To: "David Hildenbrand (Red Hat)" Cc: Mike Rapoport , Arnd Bergmann , Hugh Dickins , Andrew Morton , Pratyush Yadav , Pasha Tatashin , Arnd Bergmann , Baolin Wang , Kairui Song , Christian Brauner , Lorenzo Stoakes , Kemeng Shi , Guo Weikang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] mm: shmem: avoid build warning for CONFIG_SHMEM=n In-Reply-To: <5e40dd55-c9ea-4387-bd9b-7a4410df9898@kernel.org> (David Hildenbrand's message of "Thu, 4 Dec 2025 12:03:02 +0100") References: <20251204102905.1048000-1-arnd@kernel.org> <93782526-c198-4590-b96b-c4f630b8ecbb@kernel.org> <5e40dd55-c9ea-4387-bd9b-7a4410df9898@kernel.org> Date: Thu, 04 Dec 2025 14:34:00 +0100 Message-ID: <86ms3yl6bb.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Dec 04 2025, David Hildenbrand (Red Hat) wrote: > On 12/4/25 11:55, Mike Rapoport wrote: >> On Thu, Dec 04, 2025 at 11:34:24AM +0100, David Hildenbrand (Red Hat) wrote: >>> On 12/4/25 11:28, Arnd Bergmann wrote: >>>> From: Arnd Bergmann >>>> >>>> The newly added 'flags' variable is unused and causes a warning if >>>> CONFIG_SHMEM is disabled, since the shmem_acct_size() macro it is passed >>>> into does nothing: >>>> >>>> mm/shmem.c: In function '__shmem_file_setup': >>>> mm/shmem.c:5816:23: error: unused variable 'flags' [-Werror=unused-variable] >>>> 5816 | unsigned long flags = (vm_flags & VM_NORESERVE) ? SHMEM_F_NORESERVE : 0; >>>> | ^~~~~ >>>> >>>> Replace the two macros with equivalent inline functions tto get the >>>> argument checking. >>>> >>>> Fixes: 6ff1610ced56 ("mm: shmem: use SHMEM_F_* flags instead of VM_* flags") >>> >>> That's still not upstream, right? >>> >>> $ git tag --contains 6ff1610ced56 >>> mm-everything-2025-11-29-19-43 >>> mm-everything-2025-12-03-23-49 >>> next-20251201 >>> next-20251203 >>> next-20251204 >>> >>> So we can likely just squash it into the problematic commit before >>> proceeding with it? >> It's mm-nonmm-stable, I don't think fixups can go there. > > Ah, I only looked at mm-stable and mm-unstable. > > Confused why this is in nomm-stable and not mm-stable. The patch came in with the liveupdate series [0], most of which counts as nonmm I suppose. [0] https://lore.kernel.org/all/20251125165850.3389713-1-pasha.tatashin@soleen.com/ [...] -- Regards, Pratyush Yadav