From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC014C43381 for ; Thu, 14 Feb 2019 10:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC937222A1 for ; Thu, 14 Feb 2019 10:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438445AbfBNK6d (ORCPT ); Thu, 14 Feb 2019 05:58:33 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:41402 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395466AbfBNK5d (ORCPT ); Thu, 14 Feb 2019 05:57:33 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 732A8EBD; Thu, 14 Feb 2019 02:57:33 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6BE9D3F575; Thu, 14 Feb 2019 02:57:30 -0800 (PST) Date: Thu, 14 Feb 2019 10:57:27 +0000 Message-ID: <86mumyskmg.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , Thomas Gleixner , Jason Cooper , David Lechner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 20/37] ARM: davinci: aintc: move timer-specific irq_set_handler() out of irq.c In-Reply-To: <20190212103835.7768-21-brgl@bgdev.pl> References: <20190212103835.7768-1-brgl@bgdev.pl> <20190212103835.7768-21-brgl@bgdev.pl> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Feb 2019 10:38:18 +0000, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > I've been unable to figure out exactly why, but it seems that the > IRQ_TINT1_TINT34 interrupt for timer 1 needs to be handled as a > level irq, not edge like all others. > > Let's move the handler setup out of the aintc driver where it's lived > since the beginning and into the dm* SoC-specific files where it > belongs. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/mach-davinci/dm355.c | 8 ++++++++ > arch/arm/mach-davinci/dm365.c | 8 ++++++++ > arch/arm/mach-davinci/dm644x.c | 8 ++++++++ > arch/arm/mach-davinci/dm646x.c | 8 ++++++++ > arch/arm/mach-davinci/irq.c | 3 --- > 5 files changed, 32 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-davinci/dm355.c b/arch/arm/mach-davinci/dm355.c > index c7cd765114af..a732f2ea1d9a 100644 > --- a/arch/arm/mach-davinci/dm355.c > +++ b/arch/arm/mach-davinci/dm355.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -744,6 +745,13 @@ void __init dm355_init_time(void) > psc = ioremap(DAVINCI_PWR_SLEEP_CNTRL_BASE, SZ_4K); > dm355_psc_init(NULL, psc); > > + /* > + * Nobody knows why anymore, but this interrupt has been handled as > + * a level irq from the very beginning of davinci support in mainline > + * linux. > + */ > + irq_set_handler(DAVINCI_INTC_IRQ(IRQ_TINT1_TINT34), handle_level_irq); > + I've said it on v2, I'm repeating it on v3. There is no point in duplicating this pointless hack on and on again. If there is a driver using this interrupt, move the setup there, and fix the irq_set_type callback. If nothing is using it, remove it altogether. Thanks, M. -- Jazz is not dead, it just smell funny.