From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C39E38F93B; Fri, 2 Oct 2026 15:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790954970; cv=none; b=tBKLi6w875xFL5Km+uUt1BaMkT+nNncrgSgxKL3+opvHpjPY68+YA28lGpd8GuY1LLZprFhXKRl6Y/AEyYTmp6m2SubtJy2HsQ3hUHMNLuaIONbEAPIYMIKyM2YYzh0wYRTgFpuhj9AG2esLNrFEg+UR4wv1ULPUF84/rahEvS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790954970; c=relaxed/simple; bh=f0O0lGPSDcRSoFDtp6u/8kF+9fEtmWXKHGD/Lq4it9E=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=U7oiggQGfuZEv+WS1XZxDxeHiErseHL4sjZTDdYmhqGR01CkcMAZOqKX/QovNAMHRilPI0Kbq0wTX4WhzPw4d3sBiiXVFe1buix4CVPCCZdkzWPQuJZ+5D0fp9pLqGpC0LcgJ6SRW3PZQU/MrFnSXGivyTghKOi64nCxK4pBpZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MsvbBDri; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MsvbBDri" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE6371F000FF; Fri, 2 Oct 2026 15:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790954969; bh=w2qbnlCfWtpMJpTInUhAzDoS27bFsbxCID6JcqdfH9o=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=MsvbBDriLGUBuPkGG+TXOygYtreoDOfk5yRbhxaHuznlHbq81x4XHJ0sVS+UcJfp7 WLFCTfvNzAMIvgU5jdnaM1XfSRKf4Bgr320idBQLXxYjErS/nnik2TpwvqQFb5guin fyKzfDkG9wI7FblnrQzKraetRR4WiINQMf3e7hHZhOIC1uklkIFdPe4IRixnUgyCrH AFmjieMklHpJ/pLLWLAhBijwJWbPSniaQQzoVIIPHzzX71JbiUgZAcc8q3BkXDPHWn dZt5G8A4SPW0YIU4YrIcfA1Br27tIbE4k8RkoOj1m+tfFRoMURs5q/c7xESNJbmR/J uYUezl/z+iNmg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xCfCQ-0000000GHfm-2FHs; Fri, 02 Oct 2026 15:29:26 +0000 Date: Fri, 02 Oct 2026 16:29:26 +0100 Message-ID: <86o6dc2ka1.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: Suzuki K Poulose , kvm@vger.kernel.org, kvmarm@lists.linux.dev, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com, joey.gouly@arm.com, yuzenghui@huawei.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, sdonthineni@nvidia.com, alpergun@google.com, fj0570is@fujitsu.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org, enju.kohei@fujitsu.com, sudeep.holla@arm.com, jonathan.cameron@oss.qualcomm.com Subject: Re: [PATCH v21 05/23] KVM: arm64: Track the type of VM in kvm_arch In-Reply-To: References: <20261001210703.1597150-1-suzuki.poulose@arm.com> <20261001210703.1597150-6-suzuki.poulose@arm.com> <86se2o2rbs.wl-maz@kernel.org> <86pkxs2npx.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, suzuki.poulose@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com, joey.gouly@arm.com, yuzenghui@huawei.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, sdonthineni@nvidia.com, alpergun@google.com, fj0570is@fujitsu.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org, enju.kohei@fujitsu.com, sudeep.holla@arm.com, jonathan.cameron@oss.qualcomm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 02 Oct 2026 15:37:00 +0100, Fuad Tabba wrote: > > Hi Marc, > > On Fri, 02 Oct 2026 15:15:06 +0100, Marc Zyngier wrote: > [...] > > Honestly, we introduce the flavor stuff to make it easy to match > > things on a particular VM type in a readable way. So why isn't this > > reading: > > > > if (vcpu->kvm->arch.vm_flavor != VM_PROTECTED_PKVM) > > return; > > I know this is a sketch, but just in case: that's inverted. The sync > only applies to non-protected pKVM VMs (EL2 ignores it for protected > ones), so it would be != VM_PKVM. See what I meant about this stuff being completely intractable? I still have no idea what it means! ;-) M. -- Without deviation from the norm, progress is not possible.