From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE20C43381 for ; Thu, 14 Feb 2019 10:55:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE3C5222A4 for ; Thu, 14 Feb 2019 10:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406820AbfBNKzV (ORCPT ); Thu, 14 Feb 2019 05:55:21 -0500 Received: from foss.arm.com ([217.140.101.70]:41334 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726989AbfBNKzV (ORCPT ); Thu, 14 Feb 2019 05:55:21 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7CEDEBD; Thu, 14 Feb 2019 02:55:20 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9EEE93F575; Thu, 14 Feb 2019 02:55:18 -0800 (PST) Date: Thu, 14 Feb 2019 10:55:15 +0000 Message-ID: <86o97eskq4.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Sekhar Nori Cc: Bartosz Golaszewski , Kevin Hilman , Thomas Gleixner , Jason Cooper , David Lechner , , , Bartosz Golaszewski Subject: Re: [RESEND PATCH v2 17/33] ARM: davinci: aintc: move timer-specific irq_set_handler() out of irq.c In-Reply-To: References: <20190211122606.8662-1-brgl@bgdev.pl> <20190211122606.8662-18-brgl@bgdev.pl> <67127a57-3d1f-5cf4-efb8-f1a2a49b3a2a@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Feb 2019 05:51:11 +0000, Sekhar Nori wrote: > > On 11/02/19 6:30 PM, Marc Zyngier wrote: > > On 11/02/2019 12:25, Bartosz Golaszewski wrote: > > >> + /* > >> + * Nobody knows why anymore, but this interrupt has been handled as > >> + * a level irq from the very beginning of davinci support in mainline > >> + * linux. > >> + */ > >> + irq_set_handler(DAVINCI_INTC_IRQ(IRQ_TINT1_TINT34), handle_level_irq); > >> + > > > > Now, the real question is: why isn't that set as part of the > > set_irq_type() callback, instead of hardcoding it in the platform? > > > > This is exactly the kind of information that should come as part of the > > DT or from the driver as one of the request_irq() flags. > > > > It would save quite a bit of boilerplate code. > > True, but I would keep this series feature/bug compatible with existing > code. Without that, tracking regression reports will be a nightmare. Its > a pretty major change already. > > We can (and should) fix this, but I prefer thats done as follow-up patch > after this series is merged. That way a revert is easy. And I'd rather see it done already, as a preliminary to this series. If I'm going to take 35 patches that are mostly churn, surely we can another couple to fix something that is a real bug. > BTW, I don't quite see which in-kernel module uses this interrupt. It > might be some out-of-tree code, or some code that since got removed from > kernel. Yet another reason to fix it now. Thanks, M. -- Jazz is not dead, it just smell funny.