Re: [PATCH] genirq/PM: Fix IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND if depth > 1

[Marc Zyngier <maz@kernel.org>]

Hey Doug,

On Tue, 13 May 2025 01:32:52 +0100,
Douglas Anderson <dianders@chromium.org> wrote:
> 
> The IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag doesn't work properly if the
> IRQ disable depth is not 0 or 1 at suspend time. In this case, the
> IRQ's depth will be decremented but the IRQ won't be enabled to wake
> the system up. Add a special case for when we're suspending and always
> enable the IRQ in that case.

For my own edification, can you explain why you end-up in this
situation? Because I think I can see a use case for the current
behaviour, where a driver controls whether it wants to use this
interrupt as a wake-up source or not dynamically, irrespective of the
underlying chip's capabilities (which I suspect is pinctrl-msm).

This is also consistent with the way disable_irq() nests, making
IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND the equivalent of an enable_irq()
call.

I have the feeling this outlines an issue in the endpoint driver, more
than a core code deficiency.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.