From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBCF2279DC0 for ; Thu, 4 Dec 2025 13:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855115; cv=none; b=i9MvDykzwUNUO95PNmpbcK0XJbEThgqYJLgtUcra5AvbA0vQJToqYfSv1gT810mz/WE7/peEov8OZQ2cHz6MfN+eQ9vRxCvbAbXHeNvKCUws9mM9Agen20ydcjAVfl9pQFCJQ9KtSw4pX5b+uIlNXMg1vAjLoTfsf0VC37oiwps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855115; c=relaxed/simple; bh=vB0xFKHvvz9CMHiXhSjsKWzNa3U5EY8LSLMpWjHkcD4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kipjxweiwIxnJhOwyT/7Wi/tpI6PtRm+b+L+U7jIvJZ0CqrWicZB8WGdddJAgBXVdv87yrZO9dctl7CdmSXT/ydBE6di6rtjv9aK/eTcAIuoHKYAQfUx+6B+X+Ce1EPsBaikM95gNtiOSIa5yp4go8RZPl+RHu46/G0p7HYq8V4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WA7ZaIof; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WA7ZaIof" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EBCBC116B1; Thu, 4 Dec 2025 13:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764855114; bh=vB0xFKHvvz9CMHiXhSjsKWzNa3U5EY8LSLMpWjHkcD4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WA7ZaIofBp98YOhcsvMjQjNfKxnNEycNG1QKaMUu7DS+0Q7+s6XKOmJpSjZq949w1 CwUew8dklDN+Z8awuif8pTdKVyVO+BexdxclflU0gO9q1IyjSGKobVsT6L6y3BjRDW XgSvt5QxUF+9XINpCmdy7Kd34e+ZDiaAGkvnfQDLklgL+GG7SW84iOnWikJjtqyhUf XUSVv3GTXEpxn3yMAiOT/2zQ/8sazlrEJc8C1Ka4p05vYGaPtTyO73yB6wQlliblYM YnFhZknGzAKtmsi4PDMmRjrp6ly7YVhiHkTXGHe6y+G817oklmLTX0uVWE4Z7Rsbn8 DXNT+m3TB8vqw== From: Pratyush Yadav To: Arnd Bergmann Cc: Hugh Dickins , Andrew Morton , Pratyush Yadav , "Mike Rapoport (Microsoft)" , Pasha Tatashin , Arnd Bergmann , Baolin Wang , Kairui Song , David Hildenbrand , Christian Brauner , Lorenzo Stoakes , Kemeng Shi , Guo Weikang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] mm: shmem: avoid build warning for CONFIG_SHMEM=n In-Reply-To: <20251204102905.1048000-1-arnd@kernel.org> (Arnd Bergmann's message of "Thu, 4 Dec 2025 11:28:59 +0100") References: <20251204102905.1048000-1-arnd@kernel.org> Date: Thu, 04 Dec 2025 14:31:47 +0100 Message-ID: <86qztal6f0.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Dec 04 2025, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added 'flags' variable is unused and causes a warning if > CONFIG_SHMEM is disabled, since the shmem_acct_size() macro it is passed > into does nothing: > > mm/shmem.c: In function '__shmem_file_setup': > mm/shmem.c:5816:23: error: unused variable 'flags' [-Werror=unused-variable] > 5816 | unsigned long flags = (vm_flags & VM_NORESERVE) ? SHMEM_F_NORESERVE : 0; > | ^~~~~ > > Replace the two macros with equivalent inline functions tto get the > argument checking. > > Fixes: 6ff1610ced56 ("mm: shmem: use SHMEM_F_* flags instead of VM_* flags") > Signed-off-by: Arnd Bergmann Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav