From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7B8C43381 for ; Mon, 1 Apr 2019 02:02:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E18020870 for ; Mon, 1 Apr 2019 02:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731510AbfDACC3 (ORCPT ); Sun, 31 Mar 2019 22:02:29 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53974 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbfDACC3 (ORCPT ); Sun, 31 Mar 2019 22:02:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 542BD374; Sun, 31 Mar 2019 19:02:28 -0700 (PDT) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 93EC43F690; Sun, 31 Mar 2019 19:02:20 -0700 (PDT) Date: Mon, 01 Apr 2019 03:02:17 +0100 Message-ID: <86r2am5vpy.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Hanna Hawa Cc: , , , , , , , , , , , , , , , , , , , , , Lorenzo Pieralisi Subject: Re: [PATCH 0/7] al-msi: Rename driver and add support for ACPI In-Reply-To: <1554035655-11352-1-git-send-email-hhhawa@amazon.com> References: <1554035655-11352-1-git-send-email-hhhawa@amazon.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 Mar 2019 13:34:08 +0100, Hanna Hawa wrote: > > This series includes three major changes: > 1. IOMMU DMA mapping MSI message fix. > 2. Re-name the AL-MSIx driver to new name convention. > 3. Add ACPI support for the driver. > > Alpine is the name of the SoC family, while AL stands for Annapurna > Labs. Rename to the latter since the driver will appear in other SoC > families other than Alpine. > > The AL-MSIx controller is not standard, is not included in the UEFI > specification, and will not be added. The driver ACPI binding is > performed when the following conditions are true: > - OEM ID is AMAZON > - MADT table type is 0x80 (part of the OEM reserved range). [+Lorenzo, as the arm64 ACPI maintainer] So you're happy to explicitly violate the letter of the specification? That's not really going to fly. We've pushed back on such things in the past (MBIGEN, XGene MSI controller), and I don't see any compelling reason to change our tune. > GICv2m driver is called from context of parent interrupt controller, > which ensures that the parent interrupt domain exists and holds valid > information. As calling AL-MSIx driver from GICv3 driver would not make > sense, a new API was added, to get the GSI IRQ domain that was registered > by GICv3 driver in the ACPI framework. What does this mean? Either your system has a GICv2m or it has a GICv3. Please explain what this is all about. Thanks, M. -- Jazz is not dead, it just smell funny.