From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ECC9C43381 for ; Thu, 14 Feb 2019 10:43:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB08C222A4 for ; Thu, 14 Feb 2019 10:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406710AbfBNKnN (ORCPT ); Thu, 14 Feb 2019 05:43:13 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:41060 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388285AbfBNKnM (ORCPT ); Thu, 14 Feb 2019 05:43:12 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4186FEBD; Thu, 14 Feb 2019 02:43:12 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 87AF63F575; Thu, 14 Feb 2019 02:43:09 -0800 (PST) Date: Thu, 14 Feb 2019 10:43:06 +0000 Message-ID: <86r2caslad.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Aaro Koskinen Cc: Thomas Gleixner , Jason Cooper , , , "Rafael J. Wysocki" , Ralf Baechle , Paul Burton , James Hogan Subject: Re: [PATCH] irqchip/i8259: fix shutdown order by moving syscore_ops registration In-Reply-To: <20190207205812.GA11315@darkstar.musicnaut.iki.fi> References: <20190206212608.27189-1-aaro.koskinen@iki.fi> <8492440b-b489-0ce1-865c-4505042cb061@arm.com> <20190207205812.GA11315@darkstar.musicnaut.iki.fi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 Feb 2019 20:58:12 +0000, Aaro Koskinen wrote: > > Hi, > > On Thu, Feb 07, 2019 at 08:56:37AM +0000, Marc Zyngier wrote: > > On 06/02/2019 21:26, Aaro Koskinen wrote: > > > static void init_8259A(int auto_eoi) > > > { > > > unsigned long flags; > > > @@ -332,6 +324,7 @@ struct irq_domain * __init __init_i8259_irqs(struct device_node *node) > > > panic("Failed to add i8259 IRQ domain"); > > > > > > setup_irq(I8259A_IRQ_BASE + PIC_CASCADE_IR, &irq2); > > > + register_syscore_ops(&i8259_syscore_ops); > > > return domain; > > > } > > > > > > > > > > Given that this is a change of behaviour that is likely to affect other > > platforms (I see at least another 6 MIPS machines using the i8259), > > could someone make sure that this doesn't cause any regression? This is > > unlikely to affect the SGI boxes, as they predate any notion of power > > management, but something like Malta could potentially be affected. > > For shutdown, I don't think there are many syscore_ops users on these > platforms. Actually I could find only two that I think could be used: > - cpufreq (issue fixed by this patch, and Loongson is the only user > anyway) > - leds-trigger > > Then suspend/resume: i8259 doesn't implement suspend, so there is no > change in behaviour. In resume it does PIC re-init, but syscore_resume() > is done with interrupts disabled so the order shouldn't matter. In the absence of any comment from the MIPS guys over the past week, I've queued this. Please let me know should it break anything. Thanks, M. -- Jazz is not dead, it just smell funny.