From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794388178; b=clNAL431+2Cg7Z8MaOoIyjW0kw4nW0Dc9AALqRFIgA8SiIAmjJ09+kkPyxMLDTAEMqpk XwWnw7UQ+uQ2towWrvSG76ieq7Xr4r1kfrkM4zl/9bHyimIV5rASLgqKORlo6zUQIb0qp e9iCHh0sJKzbGjHUfTG4/HoZ4MOSUARdjia0cA+pX/8Em0HI6HHLsEGdxcKCL2/7TSP/J GKDh+nFLUgi5rUy3v2zVlrS4CnC8mu/WuXvOWpJMFPwUbemuUGO7T2rIKsXkYbAbXv2PB st5KpWRcBBRiwSd9Uh3vGxYjVIk9WKqTDXfRTyZANwBsTm86gOBNUS5e9WrHt6kuRxA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794388178; h=Received:DKIM-Signature:Received:Date:Message-ID:From:To:Cc:Subject: In-Reply-To:References:User-Agent:MIME-Version:Content-Type: X-SA-Exim-Connect-IP:X-SA-Exim-Rcpt-To:X-SA-Exim-Mail-From: X-SA-Exim-Scanned; bh=htR73Z6NVxU0lkG220sIaALTFHPkl5m16dbexXoczJ0=; b=gZRtcEnrmtSGc3PKIF0//f3v8L2coMimajOn7sb+pc7F2ZaknCXBbt+A5sEt4tH5aGFv 1uXWBZ6kTS9G+hfrGQXCVWL+f4uM61j4ju0t8EOBfpPd/O7pzcPaNS8BQjpCPDE2X6iTj 7X5t1KI1kTPaViZDne7bOVFSm9HM0LqaK+fMUkelzGFYfM+KvJ9P7buuG4tCuPKllf03L gnTRyMQJQjbt9n3/LTiGjtmjCZ3PffiwnuvxVL0fNdS2UfAgzkg1bs6hsYr2I7zTP0OiU uOKmo3bfzeDo3SFprfFeLJZlk8peNk5G+/BZC4AK/MCXT5MeOkp1tVqT3+5cNIKpYSg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FiDTk9HN; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1365606A31C for ; Wed, 11 Nov 2026 09:09:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FiDTk9HN Received: by smtp.kernel.org (Postfix) with ESMTPSA id 825D31F00A05; Wed, 11 Nov 2026 09:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794388177; bh=htR73Z6NVxU0lkG220sIaALTFHPkl5m16dbexXoczJ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=FiDTk9HNHaNkX2ypeG3Omgun2J6T0+Ry4iViwS3mepi1nuRCo7SACBz5SN99gYFNj HauQ3qwNyKf6GiL7+xIpDQvB42fI6P6B0ESdm8HUPTaQlvv7obkPOydwo7h+WnwJB9 fb65GIj4iVHHm/ZGShyjXfgPxehyGD/kE/c9d1a9fgnLyBHl0Yf7uMLdYLmy4RUMLD pwphhR639xg6/qsmD1Qd5QBhUACptY36zXITFA3P7Qd/RwT5RNcVagPWjR2qUCCAy+ JKJ+eJkC+V9pqMVQkI7YVdw6af11rZiiLpRUUa86Usw0dJ8JDSryncBTLF1MrNvumo txEKZLdHgXiMQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xR4Kl-0000000ECif-06Cb; Wed, 11 Nov 2026 09:09:35 +0000 Date: Wed, 11 Nov 2026 09:09:34 +0000 Message-ID: <86se1720q9.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: Thomas Gleixner , Radu Rendec , Steven Price , Suzuki K Poulose , Will Deacon , Fuad Tabba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] irqchip/gic-v3-its: Fix the ITT pool's alignment, zeroing and growth In-Reply-To: <20261106092625.3977163-1-fuad.tabba@linux.dev> References: <20261106092625.3977163-1-fuad.tabba@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, tglx@kernel.org, radu@rendec.net, steven.price@arm.com, suzuki.poulose@arm.com, will@kernel.org, tabba@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 06 Nov 2026 09:26:22 +0000, Fuad Tabba wrote: > > Hi folks, > > Three fixes to the ITT pool that took over sub-page ITTs from > kzalloc_node(). It doesn't align them to 256 bytes, though MAPD now > relies on it to. It doesn't zero the ITTs it reuses either, and it > leaks pages when it fails to grow. > > The first gives the pool a 256-byte granule. With its 1-byte granule, > ITTs stay aligned only while every size is a multiple of 256, which > holds for power-of-two ITE sizes but not for QEMU's 12-byte ones. On > QEMU, two devices with 32 MSI-X vectors each are enough to put the > second device's ITT at an address MAPD truncates into the first's. > > The second zeroes an ITT reused from the pool, as MAPD requires. The > third frees the page when gen_pool_add() fails. How does it relate to the series you posted right after (20261106120221.347309-1-fuad.tabba@linux.dev)? They both deal with all sort of zeroing and allocation requirements. So why isn't this one single consistent series? The scatter-gun approach you keep using is really becoming counter-productive. I really appreciate the effort you are putting in fixing the code, but please realise that humans are reviewing this, not an AI. So please make it at least easy to track and keep related things together. Thanks, M. -- Without deviation from the norm, progress is not possible.