From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75E1C43218 for ; Sun, 28 Apr 2019 09:33:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2E3E2075D for ; Sun, 28 Apr 2019 09:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726575AbfD1Jdv (ORCPT ); Sun, 28 Apr 2019 05:33:51 -0400 Received: from foss.arm.com ([217.140.101.70]:54910 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfD1Jdv (ORCPT ); Sun, 28 Apr 2019 05:33:51 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EB06374; Sun, 28 Apr 2019 02:33:50 -0700 (PDT) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A2E3F3F5AF; Sun, 28 Apr 2019 02:33:47 -0700 (PDT) Date: Sun, 28 Apr 2019 10:33:54 +0100 Message-ID: <86sgu2a2yl.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Anson Huang Cc: Mukesh Ojha , "tglx@linutronix.de" , "jason@lakedaemon.net" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx Subject: Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code In-Reply-To: References: <1554099427-5240-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 Apr 2019 07:28:20 +0100, Anson Huang wrote: > > Ping... I'm still building the 5.2 branch, no need to panic just yet. Thanks, M. > > > -----Original Message----- > > From: Mukesh Ojha [mailto:mojha@codeaurora.org] > > Sent: Monday, April 1, 2019 3:47 PM > > To: Anson Huang ; tglx@linutronix.de; > > jason@lakedaemon.net; marc.zyngier@arm.com; shawnguo@kernel.org; > > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Cc: dl-linux-imx > > Subject: Re: [PATCH] irqchip/imx-irqsteer: use > > devm_platform_ioremap_resource() to simplify code > > > > > > On 4/1/2019 11:51 AM, Anson Huang wrote: > > > Use the new helper devm_platform_ioremap_resource() which wraps the > > > platform_get_resource() and devm_ioremap_resource() together, to > > > simplify the code. > > > > > > Signed-off-by: Anson Huang > > Reviewed-by: Mukesh Ojha > > > > Cheers, > > -Mukesh > > > --- > > > drivers/irqchip/irq-imx-irqsteer.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c > > > b/drivers/irqchip/irq-imx-irqsteer.c > > > index 88df3d00..290531e 100644 > > > --- a/drivers/irqchip/irq-imx-irqsteer.c > > > +++ b/drivers/irqchip/irq-imx-irqsteer.c > > > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct > > platform_device *pdev) > > > { > > > struct device_node *np = pdev->dev.of_node; > > > struct irqsteer_data *data; > > > - struct resource *res; > > > u32 irqs_num; > > > int i, ret; > > > > > > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct > > platform_device *pdev) > > > if (!data) > > > return -ENOMEM; > > > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > - data->regs = devm_ioremap_resource(&pdev->dev, res); > > > + data->regs = devm_platform_ioremap_resource(pdev, 0); > > > if (IS_ERR(data->regs)) { > > > dev_err(&pdev->dev, "failed to initialize reg\n"); > > > return PTR_ERR(data->regs); -- Jazz is not dead, it just smell funny.