From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D05C7618B for ; Mon, 29 Jul 2019 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4212206E0 for ; Mon, 29 Jul 2019 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbfG2JtF convert rfc822-to-8bit (ORCPT ); Mon, 29 Jul 2019 05:49:05 -0400 Received: from foss.arm.com ([217.140.110.172]:40918 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbfG2JtF (ORCPT ); Mon, 29 Jul 2019 05:49:05 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40B041570; Mon, 29 Jul 2019 02:49:04 -0700 (PDT) Received: from big-swifty.misterjones.org (g-dizzle.cambridge.arm.com [10.1.32.80]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94D3F3F694; Mon, 29 Jul 2019 02:49:02 -0700 (PDT) Date: Mon, 29 Jul 2019 10:49:00 +0100 Message-ID: <86tvb5mar7.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Anders Roxell Cc: Catalin Marinas , will@kernel.org, Linux ARM , kvmarm@lists.cs.columbia.edu, Linux Kernel Mailing List Subject: Re: [PATCH 2/2] arm64: KVM: hyp: debug-sr: Mark expected switch fall-through In-Reply-To: References: <20190726112710.19051-1-anders.roxell@linaro.org> <86d0hxnfif.wl-marc.zyngier@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Jul 2019 15:11:05 +0100, Anders Roxell wrote: > > On Fri, 26 Jul 2019 at 14:31, Marc Zyngier wrote: > > > > On Fri, 26 Jul 2019 12:27:10 +0100, > > Anders Roxell wrote: > > > > > > When fall-through warnings was enabled by default the following warnings > > > was starting to show up: > > > > > > ../arch/arm64/kvm/hyp/debug-sr.c: In function ‘__debug_save_state’: > > > ../arch/arm64/kvm/hyp/debug-sr.c:20:19: warning: this statement may fall > > > through [-Wimplicit-fallthrough=] > > > case 15: ptr[15] = read_debug(reg, 15); \ > > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’ > > > save_debug(dbg->dbg_bcr, dbgbcr, brps); > > > ^~~~~~~~~~ > > > ../arch/arm64/kvm/hyp/debug-sr.c:21:2: note: here > > > case 14: ptr[14] = read_debug(reg, 14); \ > > > ^~~~ > > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’ > > > save_debug(dbg->dbg_bcr, dbgbcr, brps); > > > ^~~~~~~~~~ > > > ../arch/arm64/kvm/hyp/debug-sr.c:21:19: warning: this statement may fall > > > through [-Wimplicit-fallthrough=] > > > case 14: ptr[14] = read_debug(reg, 14); \ > > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’ > > > save_debug(dbg->dbg_bcr, dbgbcr, brps); > > > ^~~~~~~~~~ > > > ../arch/arm64/kvm/hyp/debug-sr.c:22:2: note: here > > > case 13: ptr[13] = read_debug(reg, 13); \ > > > ^~~~ > > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’ > > > save_debug(dbg->dbg_bcr, dbgbcr, brps); > > > ^~~~~~~~~~ > > > > > > Rework to add a 'break;' where the compiler warned about > > > fall-through. > > > > That's not what this patch does, I'm afraid. > > urgh I'm sorry. > Sending a v2 shortly. Don't bother, I'll fix it locally. Thanks, M. -- Jazz is not dead, it just smells funny.