From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83CEA33F8B4; Tue, 15 Sep 2026 14:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789480949; cv=none; b=nNpOluDHhK5R3+nwA2/YTXf182nDT9nmQyOWt46i2hY0homJBORc6a+sT2CoSKH2sYERPdLWoNV1VE51v0kaY3HeVMit03TyM1+AjZUUloeIkKEIEckZZ2bBBntZXh5WxCjuJmSQWmhng0UkYwbhprYTLQVzGuU9kfd8Zu6qvag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789480949; c=relaxed/simple; bh=2qblHiRoIo+hFrinE4U2+cmvOsgbDeofL/9V5DGaaOY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=O2lrTxqPIDDwy0BWz/chkzPQ+/Aq1NCcqI1nShruzyoriZjk2IdtbooQ7u5+s3D6LgKqRoVAp2HfbgBmilmbvHWhHnWsFCrS2x4kEkhzHfDPkWl6S8KdTlbbKpqckZ7OO6VMiFckn/ay4qSt6heNiffSy9H14jdbDuTmkVHh3xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ElzCFfaA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ElzCFfaA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C08F1F000FF; Tue, 15 Sep 2026 14:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789480948; bh=V2+wp1JbGqyDj/eKk9M2CQpRON+IxnqrnAi1UNJPOvc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=ElzCFfaAbq9pkqV5/eUkFLt+jY8vJeCp0DXjjjL2XCBF6SLN4lkZRPCtmrniSz7CL ll9tjNaTiJXttH9BLCAm/jTrN15LD49IaVakiZBOj0N/Z1J2+87YV1H36eeeKCNC1G 6yLbHCKEb5/6AhH74iuUUrdaRFPhMMf+tFhJTGG06PofoWMz0bxVzyK76EsX1/8VNt wUO/Gn/DdQogi1sySvfHA19S98GSv53zCKKrcxvPDLwwYRWzkv2IhMehwgbfRECfJJ 08wy9em3anWOdY+xWnRxrplG9PCD6mvTcECMaSVcRcE3Gqm38lsTXRxAbfIcOEdIzg 8OpjB4Ykji/rA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x6Tjt-00000009B2D-3OhI; Tue, 15 Sep 2026 14:02:25 +0000 Date: Tue, 15 Sep 2026 15:02:25 +0100 Message-ID: <86v78662a6.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, vdonnefort@google.com, qperret@google.com, Sascha.Bischoff@arm.com, steven.price@arm.com, tabba@google.com Subject: Re: [PATCH 1/7] KVM: arm64: Reject the GICv5 CPU interface hypercalls under pKVM In-Reply-To: <20260915123846.2317931-2-fuad.tabba@linux.dev> References: <20260915123846.2317931-1-fuad.tabba@linux.dev> <20260915123846.2317931-2-fuad.tabba@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, vdonnefort@google.com, qperret@google.com, Sascha.Bischoff@arm.com, steven.price@arm.com, tabba@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 15 Sep 2026 13:38:40 +0100, Fuad Tabba wrote: > [...] > diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c > index 9a3b92e626adb..7c939baf9c1ba 100644 > --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c > +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c > @@ -911,6 +911,8 @@ static const hcall_t host_hcall[] = { > HANDLE_FUNC(__kvm_enable_ssbs), > HANDLE_FUNC(__vgic_v3_init_lrs), > HANDLE_FUNC(__vgic_v3_get_gic_config), > + HANDLE_FUNC(__vgic_v5_save_apr), > + HANDLE_FUNC(__vgic_v5_restore_vmcr_apr), > HANDLE_FUNC(__pkvm_prot_finalize), > > HANDLE_FUNC(__kvm_adjust_pc), > @@ -932,8 +934,6 @@ static const hcall_t host_hcall[] = { > HANDLE_FUNC(__tracing_write_event), > HANDLE_FUNC(__vgic_v3_save_aprs), > HANDLE_FUNC(__vgic_v3_restore_vmcr_aprs), > - HANDLE_FUNC(__vgic_v5_save_apr), > - HANDLE_FUNC(__vgic_v5_restore_vmcr_apr), > > HANDLE_FUNC(__pkvm_host_share_hyp), > HANDLE_FUNC(__pkvm_host_unshare_hyp), Why moving things in the array? The whole point of HANDLE_FUNC() is to abstract the position. M. -- Without deviation from the norm, progress is not possible.