From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BEBC7618B for ; Sun, 28 Jul 2019 10:03:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 644432075C for ; Sun, 28 Jul 2019 10:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbfG1KDg (ORCPT ); Sun, 28 Jul 2019 06:03:36 -0400 Received: from foss.arm.com ([217.140.110.172]:59972 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbfG1KDg (ORCPT ); Sun, 28 Jul 2019 06:03:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7088D344; Sun, 28 Jul 2019 03:03:35 -0700 (PDT) Received: from big-swifty.misterjones.org (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5A6303F694; Sun, 28 Jul 2019 03:03:32 -0700 (PDT) Date: Sun, 28 Jul 2019 11:03:31 +0100 Message-ID: <86wog2mq6k.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Martin Blumenstingl Cc: tglx@linutronix.de, jason@lakedaemon.net, ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, robh+dt@kernel.org, linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, john@phrozen.org, hauke@hauke-m.de Subject: Re: [PATCH 5/5] MIPS: dts: lantiq: danube: easy50712: route the PCI_INTA IRQ through EBU In-Reply-To: <20190727175315.28834-6-martin.blumenstingl@googlemail.com> References: <20190727175315.28834-1-martin.blumenstingl@googlemail.com> <20190727175315.28834-6-martin.blumenstingl@googlemail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Jul 2019 18:53:15 +0100, Martin Blumenstingl wrote: > > EBU provides an interrupt line for the PCI_INTA interrupt. Route > easy50712's PCI interrupt to EBU so the interrupt line is configured > correctly (using IRQ_TYPE_LEVEL_LOW, this was previously hardcoded in > the PCI driver) and ACKed properly. > > Signed-off-by: Martin Blumenstingl > --- > arch/mips/boot/dts/lantiq/easy50712.dts | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/lantiq/easy50712.dts b/arch/mips/boot/dts/lantiq/easy50712.dts > index 1ce20b7d05cb..33c26b93cfc9 100644 > --- a/arch/mips/boot/dts/lantiq/easy50712.dts > +++ b/arch/mips/boot/dts/lantiq/easy50712.dts > @@ -1,6 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0 > /dts-v1/; > > +#include > + > /include/ "danube.dtsi" > > / { > @@ -105,7 +107,7 @@ > lantiq,bus-clock = <33333333>; > interrupt-map-mask = <0xf800 0x0 0x0 0x7>; > interrupt-map = < > - 0x7000 0 0 1 &icu0 29 1 // slot 14, irq 29 > + 0x7000 0 0 1 &ebu0 0 IRQ_TYPE_LEVEL_LOW // slot 14 > >; > gpios-reset = <&gpio 21 0>; > req-mask = <0x1>; /* GNT1 */ > -- > 2.22.0 > Are you OK with breaking compatibility between kernel and DT? It usually isn't very nice for users... Thanks, M. -- Jazz is not dead, it just smells funny.