From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8412466B03; Mon, 21 Sep 2026 20:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790023629; cv=none; b=JAKqDYlJ1UdB1Jvl6mz+wnDnnKXA6Lp3mrcyYGPpeJobUZG1VoFSvhb9TBZAqR/oaKChcFy9+aEeBfRZ0qadWlXS0aujN88nsiyNg2XgkEoBPOrNMyrQa09oLfDUK6MS+HJmJSZh1YmHlXOp30znJYxTFH6+O3FqGTIaUXVn+6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790023629; c=relaxed/simple; bh=ilpyVqJgSU3HEse/418iMePsxtaa4i5XQ3pcDEDgqMA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=iq9H1l1Hnm/UXmVqcUZwES7W1fGyNaE7X0OD5aViz6/UXKKx34tU2JJUbbKh7QRjHBQrHxeVq2wSgli56vufR5oqSAcljV2V28zCOsDK7rERunnwNX4c9uySwpSYDpge/ud+BsMD/R6l1FvQhL056GVPsAHLBgVZY5N3ysJv63c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A9MyW6Cl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A9MyW6Cl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32DC61F000FF; Mon, 21 Sep 2026 20:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790023627; bh=Ko4Gf+zSQOcJcphHQgMnnkgQDY5pgWY7p9IyRHfB4/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=A9MyW6ClUIwiasLziBkZ+OyuPfsk9bbBKG4b+RgpCY+IyOnpO8MN9pQI9jbT3lytw h63Di1QbjriRdp6mSZj/zicNtlh09KHpt7vjsInlasLwulIbpM33IxoZdPMWhX/3hV ahobY/sPbiSbdW7LhjwQcfmWMJtY9/4PbKHaYV64OBYlNl1N2J2Vq1g0t70OFOS0o8 t8OtHVn2cEAqiAFqdG9iCKA2gvp6FljiF3aihnn+xoxlgp9DyufOoS/ilxE5gbkffa wbx/ZRhHxSMwIZ6X1yGbEsQpUZ1WD/NHob5Yui+WYy05RORYqh21C7ETJIHPJBQ89m 1KwfWpnmVP2vw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x8kun-0000000Bj0s-04YP; Mon, 21 Sep 2026 20:47:05 +0000 Date: Mon, 21 Sep 2026 21:47:04 +0100 Message-ID: <86y0cu49iv.wl-maz@kernel.org> From: Marc Zyngier To: Georgi Djakov , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Raviteja Laggyshetty , Konrad Dybcio , Abel Vesa , Bjorn Andersson , Mostafa Saleh , Thorsten Leemhuis Subject: Re: [PATCH] Revert "interconnect: qcom: x1e80100: enable QoS configuration" In-Reply-To: <20260915123703.3228329-1-maz@kernel.org> References: <20260915123703.3228329-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: djakov@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, raviteja.laggyshetty@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, abelvesa@kernel.org, andersson@kernel.org, smostafa@google.com, regressions@leemhuis.info X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 15 Sep 2026 13:37:03 +0100, Marc Zyngier wrote: > > This reverts commit 5a8b2cc36e796d595c9d97eab23c2be22805cc1c. > > Since the introduction of this QoS change, X1 machines based on the > Purwa SoC (such as the Lenovo Mini X) take a hard reset at boot time. > > Other machines based on Hamoa (such as the X1E001DE Snapdragon Devkit) > end-up with a similar hard reset while under load, most likely due to > the PCIe ports being starved of traffic. > > Revert the whole thing until someone figures out what magic parameters > allow QoS to work in a sensible manner, as a usable machine is somehow > preferable to one that crashes efficiently. > > Link: https://lore.kernel.org/all/apgeBNSiP01YfNcs@google.com > Link: https://lore.kernel.org/all/86ld9d4h4n.wl-maz@kernel.org > Signed-off-by: Marc Zyngier > Cc: Georgi Djakov > Cc: Raviteja Laggyshetty > Cc: Konrad Dybcio > Cc: Abel Vesa > Cc: Bjorn Andersson > Cc: Mostafa Saleh > Cc: Thorsten Leemhuis > --- > drivers/interconnect/qcom/x1e80100.c | 485 --------------------------- > 1 file changed, 485 deletions(-) Any update on applying this? These machines have been broken for the past 4 release candidates, and it'd be great to get them back to a working state. Thanks, M. -- Without deviation from the norm, progress is not possible.