From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Magnus Lindholm <linmag7@gmail.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Matt Turner" <mattst88@gmail.com>,
linux-alpha@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/13] alpha/PCI: Convert to pci_bus_size_and_assign_resources()
Date: Mon, 16 Nov 2026 22:15:23 +0200 (EET) [thread overview]
Message-ID: <87011375-bec3-5c38-3a37-a43a1de93fa6@linux.intel.com> (raw)
In-Reply-To: <CA+=Fv5SkcpskpFUCP-qDmP1vWqDiqO8FgSJJ92UvX6jGRfaGLQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3769 bytes --]
On Mon, 16 Nov 2026, Magnus Lindholm wrote:
> On Mon, Nov 16, 2026 at 4:24 PM Ilpo Järvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
> >
> > To serialize bridge window sizing and resource assignment, PCI core
> > needs to hold locks across both phases. Alpha nautilus PCI code calls
> > pci_bus_size_bridges() and pci_bus_assign_resources() separately
> > because it needs to do special resource alignment and setup after the
> > window sizes have been calculated. At least the former would seem to
> > belong to some existing __weak pcibios_*() hook but the latter might
> > need yet another pcibios_*() hook just for this single use.
> >
> > The nautilus code runs during init, so nothing is likely to race with
> > it. Converting it is mainly about consolidating the sizing and
> > assignment entry points of PCI core, which eventually allows removing
> > pci_bus_assign_resources().
> >
> > Instead of trying to do a complex rework of the code, which is risky
> > without the ability to test on the hardware, simply convert
> > pci_bus_assign_resources() to pci_bus_size_and_assign_resources(). This
> > adds a small bit of extra work by performing the sizing step again, but
> > the calculations should yield the same sizes, so it seems safe
> >
>
> Agreed. By the second pass irongate_mem has been request_resource()d, so
> pbus_size_mem() skips it as assigned, and ioport_resource is never picked
> as a window (find_bus_resource_of_type()). Only the AGP bridge's
> unassigned windows are sized again, from the same inputs.
>
> That does rely on the assigned check, though: if your follow-up series
> starts sizing assigned windows,
Yes, it will start to do that then.
> nautilus' relocated root window
> (size_windows = 1) must stay untouched by the second pass.
If the same size is calculated (during init, I see no reason why the
sizing results would change), there should be no change even when it
starts to assign windows.
I'm bit worried though when it comes to the extra alignment done by this
nautilus code as that can change the size from the original but I don't
think there is anything that would allow shrinking the window even with
that so it looks okay to me even after the upcoming series.
But it might be easiest to just set IORESOURCE_PCI_FIXED flag after the
resource has been added to the tree. That should keep the usual sizing
and assignment from touching it at all.
> It builds at every patch for the generic and Nautilus configs. I have a
> UP1100 (Nautilus), but it doesn't start up at the moment; if I get it
> running again I'll give this a boot. But for the Alpha part of this series:
Oh, that would potentially make it possible to actually try to refactor
this to happen in pcibios_*() code, which I certainly dare not without
ability test the change.
> Acked-by: Magnus Lindholm <linmag7@gmail.com>
Thanks a lot for taking a look and all the insight, it's really
appreciated.
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> > arch/alpha/kernel/sys_nautilus.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/alpha/kernel/sys_nautilus.c b/arch/alpha/kernel/sys_nautilus.c
> > index 13b79960b4b9..23a74fd4a83f 100644
> > --- a/arch/alpha/kernel/sys_nautilus.c
> > +++ b/arch/alpha/kernel/sys_nautilus.c
> > @@ -263,7 +263,7 @@ nautilus_init_pci(void)
> > if ((IRONGATE0->dev_vendor >> 16) > 0x7006) /* Albacore? */
> > IRONGATE0->pci_mem = pci_mem;
> >
> > - pci_bus_assign_resources(bus);
> > + pci_bus_size_and_assign_resources(bus);
> > pci_bus_add_devices(bus);
> > }
> >
> > --
> > 2.47.3
> >
>
--
i.
next prev parent reply other threads:[~2026-11-16 20:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:23 [PATCH 00/13] PCI: Serialize bridge window sizing and resource assignment Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 01/13] PCI: Add pci_bus_size_and_assign_resources() Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 02/13] alpha/PCI: Convert to pci_bus_size_and_assign_resources() Ilpo Järvinen
2026-11-16 19:50 ` Magnus Lindholm
2026-11-16 20:15 ` Ilpo Järvinen [this message]
2026-11-16 22:11 ` Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 03/13] PCI: Use guard(&pci_bus_sem) in pci_do_resource_release_and_resize() Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 04/13] PCI: Hold pci_bus_sem across sizing and assignment entrypoints Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 05/13] PCI: Serialize bridge window sizing and resource assignment Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 06/13] i82875p_edac: Convert to pci_assign_unassigned_bus_resources() Ilpo Järvinen
2026-11-16 15:40 ` Borislav Petkov
2026-11-16 17:11 ` Luck, Tony
2026-11-16 15:23 ` [PATCH 07/13] platform/x86: asus-wmi: " Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 08/13] platform/x86: eeepc-laptop: " Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 09/13] parisc/PCI: " Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 10/13] PCI: hotplug: octep: " Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 11/13] PCI: ftpci100: " Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 12/13] PCI: hv: " Ilpo Järvinen
2026-11-16 15:23 ` [PATCH 13/13] PCI: Remove pci_bus_assign_resources() Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87011375-bec3-5c38-3a37-a43a1de93fa6@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mattst88@gmail.com \
--cc=richard.henderson@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®