From: Michael Straube <straube.linux@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: rtl8188eu: cleanup array declaration - style
Date: Thu, 4 Oct 2018 10:20:05 +0200 [thread overview]
Message-ID: <87089eae-3cf2-8cea-b381-6e721b87ce94@gmail.com> (raw)
In-Reply-To: <223920513380c40710a833be02d86d8d6258cdab.camel@perches.com>
On 10/3/18 11:30 PM, Joe Perches wrote:
> On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
>> Cleanup array declaration to clear two 'line over 80 characters'
>> checkpatch warnings and improve readability.
> []
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> []
>> @@ -3836,24 +3836,20 @@ Following are the initialization functions for WiFi MLME
>> *****************************************************************************/
>>
>> static struct mlme_handler mlme_sta_tbl[] = {
>> - {WIFI_ASSOCREQ, "OnAssocReq", &OnAssocReq},
>> - {WIFI_ASSOCRSP, "OnAssocRsp", &OnAssocRsp},
>> - {WIFI_REASSOCREQ, "OnReAssocReq", &OnAssocReq},
>> - {WIFI_REASSOCRSP, "OnReAssocRsp", &OnAssocRsp},
>> - {WIFI_PROBEREQ, "OnProbeReq", &OnProbeReq},
>> - {WIFI_PROBERSP, "OnProbeRsp", &OnProbeRsp},
>> -
>> - /*----------------------------------------------------------
>> - below 2 are reserved
>> - -----------------------------------------------------------*/
>> - {0, "DoReserved", &DoReserved},
>> - {0, "DoReserved", &DoReserved},
>> - {WIFI_BEACON, "OnBeacon", &OnBeacon},
>> - {WIFI_ATIM, "OnATIM", &OnAtim},
>> - {WIFI_DISASSOC, "OnDisassoc", &OnDisassoc},
>> - {WIFI_AUTH, "OnAuth", &OnAuthClient},
>> - {WIFI_DEAUTH, "OnDeAuth", &OnDeAuth},
>> - {WIFI_ACTION, "OnAction", &OnAction},
>> + {WIFI_ASSOCREQ, "OnAssocReq", &OnAssocReq},
>> + {WIFI_ASSOCRSP, "OnAssocRsp", &OnAssocRsp},
>> + {WIFI_REASSOCREQ, "OnReAssocReq", &OnAssocReq},
>> + {WIFI_REASSOCRSP, "OnReAssocRsp", &OnAssocRsp},
>> + {WIFI_PROBEREQ, "OnProbeReq", &OnProbeReq},
>> + {WIFI_PROBERSP, "OnProbeRsp", &OnProbeRsp},
>> + {0, "DoReserved", &DoReserved},
>> + {0, "DoReserved", &DoReserved},
>> + {WIFI_BEACON, "OnBeacon", &OnBeacon},
>> + {WIFI_ATIM, "OnATIM", &OnAtim},
>> + {WIFI_DISASSOC, "OnDisassoc", &OnDisassoc},
>> + {WIFI_AUTH, "OnAuth", &OnAuthClient},
>> + {WIFI_DEAUTH, "OnDeAuth", &OnDeAuth},
>> + {WIFI_ACTION, "OnAction", &OnAction},
>> };
>
> Perhaps const here too, and as well, the struct
> declaration could use const char * instead of char *
>
Just to be sure, it should be
static const struct mlme_handler mlme_sta_tbl[] = {
?
next prev parent reply other threads:[~2018-10-04 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 20:43 [PATCH 1/3] staging: rtl8188eu: fix line over 80 characters " Michael Straube
2018-10-03 20:43 ` [PATCH 2/3] staging: rtl8188eu: cleanup array declaration " Michael Straube
2018-10-03 21:30 ` Joe Perches
2018-10-04 8:20 ` Michael Straube [this message]
2018-10-04 12:12 ` Michael Straube
2018-10-04 18:10 ` Joe Perches
2018-10-03 20:43 ` [PATCH 3/3] staging: rtl8188eu: rewrite if tests " Michael Straube
2018-10-03 21:26 ` [PATCH 1/3] staging: rtl8188eu: fix line over 80 characters " Joe Perches
2018-10-04 15:54 ` Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87089eae-3cf2-8cea-b381-6e721b87ce94@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®