From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754089AbdCPTU6 (ORCPT ); Thu, 16 Mar 2017 15:20:58 -0400 Received: from mail-by2nam03on0088.outbound.protection.outlook.com ([104.47.42.88]:39616 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752716AbdCPTUP (ORCPT ); Thu, 16 Mar 2017 15:20:15 -0400 Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=amd.com; Subject: Re: [RFC PATCH v2 05/32] x86: Use encrypted access of BOOT related data with SEV To: Borislav Petkov , Brijesh Singh References: <148846752022.2349.13667498174822419498.stgit@brijesh-build-machine> <148846757895.2349.561582698953591240.stgit@brijesh-build-machine> <20170307110925.zmo7gsflxhui4k7e@pd.tnic> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: Tom Lendacky Message-ID: <8715da04-2d25-d1f2-3082-f45750c4f2d9@amd.com> Date: Thu, 16 Mar 2017 14:03:58 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170307110925.zmo7gsflxhui4k7e@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR21CA0003.namprd21.prod.outlook.com (10.172.122.141) To BN6PR12MB1139.namprd12.prod.outlook.com (10.168.226.141) X-MS-Office365-Filtering-Correlation-Id: 9bc86f06-0a62-4646-e076-08d46c9f386c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:BN6PR12MB1139; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;3:Z1QOtKbX+Kon1Y1DQ7yhY1qOCg3p5/nTS35QJEhta9Fm+1Lo0UnMStx28ayCs6r94pZYI1oVkBTq9lXxIH3vEWrkgnZyIjdZQXHqrIk/w+EdMnyeUM+qCQwYff8UBabEeBfdAdB3M4t8htH7/kzZoiAy4LeaJSYaX2eWrDd8hLWafZ+rGawKXxpaE+nIzDalAhPHgI4HUCU7+a46DK+CTZWxAjqWbDwe//hnA63Mspifx07sTPZuTRpaA2IxeuJKtmE4ThTYXSVGZ+iMesKGIyHyGS6E2UUFOZsOTwyZV3s=;25:xA/ku8ZpksTHjCAYdgU/2johOKvE/gGhBi8SqPhyUrE7zES5UvEd7jIw/iA9Ii/sUzFhwgrnkKlLsjN2S/CVvfS4gChRmZWy9LVaHhVDEIIE5yWcHhF7O0l9jM54o/gr8jhJxPjSeyli2aBRUPbVSlbW8rEWVBiNMpoG0nnoa2n8JzC2Uw1VuiQ14X+nNXNj+KlH3ttsVgVxh8qRSmAkMsZ4djnDAuWEahsNCLemNlJRdX4OlwICf7sP23AboVuHfxvq40u5vv12vk4yLKme3nhbjILYH2WfmHKTu//ICNjpB46luVt7TGtLpiU305qsp2OruwQYGJXcIQbWeBdpTiTO8Pde7r/T/bfqLFIpONcBd/ftQ3Q5ShMs0LhTTJe4DcjxFB1YGWDOz03C0ftoeJtjZIAf9UN+OzGSntQah9D5V+ySlur+wOLQLRiXDPQBo8v66CUn8jaJaqgeFcRAKw== X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;31:UtAn6l9uBZnoZDe6wK6vh8X4ar4BOqA69MqToWKeg4R58ubPHyA5WNF/ViPtCELggx6p89e63eJVT2sj9k6rllyPkLyAJRvsgf2SvuWb7XgA8JLi4v3n6f2K7JityYeS68gWVnoZU6AG6m3b9Ube6slQUhCNA1+ezcv7mFoGs6ojI/v8DS41H6/aoP9cPUIBvMHasRGsEsvSgoRuNN0TW3WNedWpeRWrpC9g42ukkm3LNL6wauBmFmePdcGTbUMJ;20:LxASAu3DfVlopcKbakDlhK0WBEL5KCak9aNju46Y5ZAJXhuE+uz/mGo8iJ67ZXd4oOhORYVWtQsoJEwJSsjakxkhPyK3E8v4rRXx9V1fE5c5osH0yWfeLF2XQuIHOX9xZk45QPilsnX21Srv5vzAq1ke3ZqRsshVCWc9PN0xoK9HKNQfL5Xi/F134lZIJ31/pPH9kJvU5iZrZBnPlKmV8g15o/e3rpZWj8zKVI7OgLCMa0S3HFYSl4w8LfOT7yTjoMw2HhGNVUWpRO5MSbzMJNm1fofodxke62HG04C6zFvVkjzJpiKKwmrjmP/Vs75zJEOSxVUcEcjLALurlQUSjtf9ma6XtOfzSsdYMz8AJuczjoUiYB+WimqWc1Rzq6cJBaTOWUVIW29iT+moAj5ECfjieNl4RcpkASitHw263RZXhv5HSNjZ06oRy6P9ZBLTSkNat7aJlST7cpooM3CXCLt+8eUQCKxPeYTaF3gD7tNFWhz9tIG9Vp2SNr6q78tv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(20161123558025)(6072148);SRVR:BN6PR12MB1139;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1139; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;4:6hYJ2SM9ywHnzVupU/g/0j8Gv2ik67a6wHJl5PbzIVRtNgy6UE02wMc0RMmAZaSXs9YZwqdzJb+akDj3Z8bmDnt1DkYM67O+cTbOv8M5OJM001DPhb3wC8td6YgSKo99apkkvN9JldcUNhW343PIcrz9dwtRVK6sqeU0U3lF9rXELZcmP7xXW/DYya5+SnwVrw2Ujuht/J7fS5JPjQvL3uIqrvvPpTUgaaVrEa6d11gLvF3kATg7+jUTz4omxbQ9Frt4z7oP9t8cr5acahBy5AxQfrwOf930oDHWNSr94AbC78lYi0+X2xYDFFqXR/leuKQpv8fRPZTlMjplUoeD1vXDZxZVd6pMdzwlHXvF4IVSVj8/pcb7zP3NrTYvaqkrXfznRQtaJ3qRkLYDUIZhhFKj7Ayhl09HoiCPjCo4ZEpUyWOTEsQrkWJOx6OdXOlwL+mZEKA6sxMJL9BYNqmnPFtnXzBHb8nDbaZlGuhwah2Go7d4AfidUcrIb7+ADhCIvwrbqbN2yAexaI5SujDEddXsu4Ng3El4r+dUFztwvqmBy6KFFRbAB8g2YVuM4ixKAGiCTkLvyGssNoSf1yNK4QHQK9jm1ywlZ8AUEanqcWbWcxlWzMGu6n1qIgSXMffxg4seLV2PySzj4vuxgC2g2gJvDJQyVZEw+d5NIjdv8XQ= X-Forefront-PRVS: 024847EE92 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39450400003)(39840400002)(39860400002)(24454002)(377454003)(6116002)(77096006)(54356999)(189998001)(50986999)(31686004)(65956001)(31696002)(76176999)(6636002)(4001350100001)(65826007)(7416002)(229853002)(5660300001)(36756003)(6486002)(6666003)(230700001)(305945005)(7736002)(66066001)(33646002)(6246003)(90366009)(54906002)(23676002)(50466002)(7406005)(53936002)(8676002)(25786008)(53546007)(86362001)(81166006)(83506001)(2906002)(4326008)(38730400002)(2950100002)(42186005)(47776003)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1139;H:[10.236.64.195];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMTM5OzIzOkNiOVRXcWc1cXAxRlZTMjFYaHEyZmhlaCs5?= =?utf-8?B?am9jU1lrY01XQVFqVUx6bmVHc1EyUkhPcWpmaWdaNnZKM3d5N20vSnZDUnhR?= =?utf-8?B?NGdTUEpnV05xbTNOaklNZjZtTXJob2pZanVKWW0ybnYzWUFTNDFLbHMrMUZT?= =?utf-8?B?U0wrN3VEZjVMeHRLS3k5ZldkSUF3MVZnYmpqS2xYbmNZWFB3emhaM1VYVTkw?= =?utf-8?B?MllISi82WFdBNmo4TCtYam82MXdQanBxWE4wSmJQamZOQ0RIOHF3amFjRFZF?= =?utf-8?B?TkFHU29BbmJJMmgyZ056ZnB4TmZQYVhaK2ljR01aanQrdk5BckJjSmZJa3g2?= =?utf-8?B?dXVnQjdCaUp4NGN5VFFPOUVLeUtZZDdiRWhQV2RqOWdDVkszT2JzK2NiMmZx?= =?utf-8?B?YmxIV0VaZVFUUnZMRVRueGhRRmZlakRocFZjbGtVTGVVVk8wN1QxRjNWd1d0?= =?utf-8?B?Yng2ZkNXVzdYS1hrSGFqU1RWRDd6a0wvM1RPY0NaaXBUV09xWFl3S2RUNnFU?= =?utf-8?B?Z3g0bUxZRGEyeFoxczlRcDliZHNBQ0NiQnJFZFBlWE9MdnYxTDhiTDg5eGYy?= =?utf-8?B?N2thSFc1MW8wRzl6c3dLb2tUNVU4bkFpZUhZRnlyYlNqVjU3d0JyeEp4Ui9J?= =?utf-8?B?dVhacngwT0l2VVMvbDdUUUFLaytJVFZnb1V4dlE2UW8wMGh2VS9sNVhVSUxC?= =?utf-8?B?NmdIdEF0QmFkYU11amd0Y2Y2OC8xTFBIU1NXQW5oVThqUXAvN3pBSUllWWJ6?= =?utf-8?B?UFJpb0wvOXpJTWN2N2tNSWkyOSszVXRORXFPZmUwSXNWaHExRVVJYUNqK0hm?= =?utf-8?B?eHVJUFMzZ0hZb0FsOFVKOXB4akovZmlLMWJ6VnZSU0hzUmpOSElEeFdTellw?= =?utf-8?B?bktwVlU1YUpobWlPT0lyUDhxNFV6Uy8yeEVaZ2lQOUVzaGQ3RVU2YXhVcjlP?= =?utf-8?B?cmQ2eHZqRU5rOCtQU2Eyc0tYVzljckJwS1hCeFFFK3pOVlhmT1dZc1hodEZU?= =?utf-8?B?b1QvQWJxS3NvNi9pOE1keTRVUHJxQlBoaVpLR0tXcWRMV29QKzZaNlNabFpC?= =?utf-8?B?czJIZzFuODBRN3FUbHZTUmpZS0l6azFYVW1VbXQ0WERicWNINjJuNVU3aTV3?= =?utf-8?B?VG1GUytLZDZwM1lLNFdSbXRGYWZja1JuL3dvTm1iL3dCMFFoSTc2L1pMK2Jk?= =?utf-8?B?RFQrSm9ndEpabVplblMrbVdFM2ZlQisrbzNhKzlvTUM2c0p1QnVodEpqVVZD?= =?utf-8?B?Uk44NTlsemQwZ2x2SG1qRU5JZ25ETFJMZDJlTW1aYWxUSHBCQ0pCaGtHNVI0?= =?utf-8?B?b254U2pXUWR1T2kyaC9jdUlFd1RLSUUraXR1dWRNWVdUb2xPdUdPM1Vod0Uw?= =?utf-8?B?elR1cTlvalRKdndGZFZ5eC9zR0ptUS96b09TL2dJV2ZBUHNvL3AvZWNmelM3?= =?utf-8?B?WGRWczRFVGNNWC9hb1dVb3VVS2NBQmt2MWw5QVd3dFRoM1JwMEtWRTZITmxw?= =?utf-8?B?RElZbEp5cFErRmVLc3ErNDJOOW5NQW9rUW5VeUt6dUZrblZKeXY2ejBxYXRw?= =?utf-8?B?QnNLdHJDQ3ZKbmFzMFRyVlRBVTRlcHJkNXVhRlhmeGUwbXlXdUJIN2lTSjFp?= =?utf-8?B?bnpEbkFWcTZZcExtRHdIMWRhNDZ1VXhoQUtSWHZrOTR4SWNmWVN1K2UxZmg3?= =?utf-8?Q?CvsgGm/dP0OzKOHsYk=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;6:vD447vbokUlcY2KRtEzwTSqQwwB0mVzBiOk4/oZNYT41c9RtaqVBlLqu9FI7c42kzb6KSUPUvFORPVKVp/XBlFOR6H5tqgV9csBcMNLvqi8ewJgRuEwEj5QLR0vDMkvujPntcwF2sW6xM7PvtjOg8AhwyGfkAB9Y9Yo3hrEJPyUk6qHsaPZHiHelICAsVZIE5ltjY7WVayycwWozKdQI+yjLk1YK6KAQyoNQ30HAFVFmCdUYNf4syGRVuM07YEqO+QyBA5FgeBM/gMDCJprEyWEyGxJP8mYihQ/1WchGVR8m6/+F+y7Rz7k8ARJU4iP8adEpXQ/2lh0VsOSKTXcmNtRN4s6KBj8MbfXkhbr1G2F/lRv6e6YBwSPoP26HisjsPx9Q+Is1gfaT2DEMP7r6zRhOjRwW9WFkfWpk2SzqxVo=;5:IAVItJSCg8hVL9WfitngRlCZJSZrtdOUSTLw+mG/Cn5K6np9yrfX6EV+Fy3rsuTAD+LdQZFwkrE/3nsihdHYHYs23ZFPexewMb2Ys61Wdd+gby4RjJqeEfwpUAtPBMkIbaS9qvAOPaAI7xHTQfGawqOSIt7rFn3y4eiL+OYn5TA=;24:mWJehmrbXXpco2IwWeCmihaGZoX/WerKaxJfecfad9MTPU+IUKCgttCuuk5m6wFHlEacbcd5xXIbinBxJQ67mP6d2NkPUSAHCLPrMgf0JLQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;7:wpIDj6r75gvTm4JMZoIB5wbRdl52HFoBG47CG8yv9XO/dLqLLPCkcQ6wXxN0iwJqUkFJ7UnLiNuACxVuF17ydQ5ctkMLbiCCrXHQN1wX/jD2eGs0eUkClAnU2GYc/i63nnkCKsK/jHWhIQOVDL73z+qSGAlqk6jhWoTgzP+ovtK8/C9pYDe5R2vcl4CtQ4nyl5rXQj6/mmRvUfwUebtxEzaXCRRPKpq0ltiJkVieZ0jPf7vo8jO9GGHTAlrk+pJn3+bow/D03GMzKOa0H9uGrhQHG6633oK8tNBHRIApjrxVqLr6enD2HhIK0q4nLI1K929LjESaJ/AJffdSBmK6sw==;20:VTF2hTcm0CUScob7R85/R5UXu6+QgcP29m7wPJT7TLEsXwW5ZmvV6xBYI+PKnlIPGIhILpySYUdQMFOLvtgHQ24QPmsNgWc0aFkOKKDMtl9e+W9426Tq2fd5vR3We2JoGkjklKzxLSAv1YcE31ftDGwT3sIfUgtDvGfPtlstFT8ykDGOOGFGap3ALIkVrjqocpCW5+Ph18VKVYK2EGbnKgWG2rryq6FsEBdMBnUcowkc9Tcz71zhPl5TYIHcoAvY X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2017 19:04:02.0111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/7/2017 5:09 AM, Borislav Petkov wrote: > On Thu, Mar 02, 2017 at 10:12:59AM -0500, Brijesh Singh wrote: >> From: Tom Lendacky >> >> When Secure Encrypted Virtualization (SEV) is active, BOOT data (such as >> EFI related data, setup data) is encrypted and needs to be accessed as >> such when mapped. Update the architecture override in early_memremap to >> keep the encryption attribute when mapping this data. > > This could also explain why persistent memory needs to be accessed > decrypted with SEV. I'll add some comments about why persistent memory needs to be accessed decrypted (because the encryption key changes across reboots) for both SME and SEV. > > In general, what the difference in that aspect is in respect to SME. And > I'd write that in the comment over the function. And not say "E820 areas > are checked in making this determination." because that is visible but > say *why* we need to check those ranges and determine access depending > on their type. Will do. Thanks, Tom >