From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 257BF417BC3 for ; Mon, 3 Aug 2026 16:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785773490; cv=none; b=HxOFvuET0Bo9AddQgIipv43CHDjYt7cl6Sp3cNO9OPDV22iJQuFHY0rajjfcCT7+S3UEJpZ//h6q7uc6ohMlaTjrmKDxG5RBjSi6J1wTJ9n2jSfTSAzeBV/NH/X0yR9VdMilvjTQncV3t9VrLHnDJ6WReCVX8MrVgqI8FvbZQXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785773490; c=relaxed/simple; bh=tMAQFxPXIx7PAQxYZjLH9+dSz17NuOukCvxxyeC2GsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iIa4fStSkNcw4fTpF+zUB7rI9jV+5sklYZZ78v1+7XUMQAKAkwzNBWphvEP5AVwajPPGfFJ2skVSPoJr2E9NTBuABM6PH5MmjNlSZUo2HGkemhyfOevh/66KT7KbOFbtK0X2emtI9toMcrCPsahz98lZeWjqjvnmobM10Q0TNM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FJ4+NyFI; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FJ4+NyFI" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so23378325e9.2 for ; Mon, 03 Aug 2026 09:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785773487; x=1786378287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WnZE5eYLucvHUcpEznH4hSEo3d2Mtfchio0f8Z2eXVU=; b=FJ4+NyFIPkc5JJr9QYs/4s7a2kG+vzLIeA6AU2HsGbGYhhfP/mDgYLBFu51dw0OfXv gf+Ow+lcmiC2d70Qh7L5yst6k/R6bGxmp5Jel3xDoKxDYLnfrbGXdd3UP9Jtnn1PV3X0 lGbaQ8ptsXSkToehfkubhi5/MHtb/GU1MbywnJx0fPnV/ulYfhS4QzzKT6n5xemNxnnF nn/LFqJZkDT8+1/m7G7C9S8wdkf33k9hoVUSowLb5rLe4Q3nzlkDKwgPFW30ZDzeQ6X/ RbVCwyKlkQYd3DbF2wg3R3WZ+BHhpQpV6ZVtSObjvTknnrYtEmtaVgP/zRoofpuHpsCl TjlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785773487; x=1786378287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WnZE5eYLucvHUcpEznH4hSEo3d2Mtfchio0f8Z2eXVU=; b=IUAIBnyv8bVjlbQ4fR5NED5veUXMqc9BsvfSZn+lcreNT2jb2Lykl+zY6rk9mnjHPS 9cgbox9NEktwbcr31j7sq++vsiADIUBk2u+QCuwaW2tCvtghcf6HeQCFR62CnOweAxNF esl8xmO5LMT0dejl01qFcnLSSV6gPj4hMCtEgjNRwZBSqlnHa1wCZMZz6Y4td2SdqOrn 6mrp/UkUU4ognvk1VYAT75fPEebQ99du0Lj4SFulOCX9MDDz7VQmghZ8vU2+DKWcgpLu ufYTsAw/h0Z2iefPRpgdfbNsu3LwO1x2/pISkAqXioyfdaqgHx8y9fJMykNjM1IffcIZ lNJg== X-Forwarded-Encrypted: i=1; AHgh+RoVDAJjkxQjMwSAjlPLghUUwHzFN5FMeCRIXdNJ8dlMJLV4cGUxZcehAXxPaP6PfSAcPDN0My7TYfeit0s=@vger.kernel.org X-Gm-Message-State: AOJu0YxadKnLxsTUPvO4P2S0WiMr4u95JI3u6u0nrWpuYdxJsIv7aylZ aU3pzZFD1TgW1o8c96GB3OZ0uWKczHsYqChZN0SVqw/VwY1JvQQjJ0yq X-Gm-Gg: AR+sD12d9YTi+4TmRAM5mdRSIorpvgvlxo5eeHeOJ77VMYyIvqBI6pp4gyJgSY2SV3R aCI9jiK54jVqSoSpm5QdeQU9RHfMVwx9/bunezQVI3o3ZsrW3U92geyVEQbU33+g5UGbDSiV2ol YvfJ9ezoMZrOaKkwqBP51dKmvDaTiITIwe11Cn/syMePRhdFf8aVE3RYbf9h6Wup2WswiXqp9NK kWeRh8OjMm3AOdQcM4OCKo+jXk+IHWCsES2hWlyeaczOIrANnWeipZjsX4k5lDLKqgv04YmUKVw ldMIyjzEhkyeVoleOfkjJRZIItvUxtqv/5tSjBXEBmLKl6i9DZAQmoiF37OSM91/jDhUkhmNZHp 5PYGsoVNabZ4dtI8HZlamPfPnTTe0PDBsRUshNhuA6+YY+IjezR+XuY+fFhXMqEjO6vhLbj+ZYa 5jFLQhILFz3pRuTAOaxnm6lnYz7sOFyMspLw/HPp7txXEyABQ/zMzNWhS0b7J5gDROLR/rggOdM 7yHyvCbPhKLWBFHlE9FNUDhSRrr4Fs8e7xsTty45WioS9tagA4d7KjAKhG1SCxxZmpaqfSQ5fUe nlIPC0q12X3kkYWnikDBbM55lTb5joMOJKrASn60ANt9rqcWjNTPpNIJKYbX8+NgZ377PkdSNMS gAXl7Pon/lZ3Oe11ofx9UkAIRCKr5a3AyoETkftsZ525WYGG5dYfftOmFsuvytnRfNZmstdtlNt rPjY52AKv2iDGUJg== X-Received: by 2002:a05:600c:4f87:b0:490:c6c2:52 with SMTP id 5b1f17b1804b1-4980c66c7d9mr217127655e9.3.1785773487184; Mon, 03 Aug 2026 09:11:27 -0700 (PDT) Received: from jernej-laptop (APN-122-100-117-gprs.simobil.net. [46.122.100.117]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fc2da2sm3363735e9.3.2026.08.03.09.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 09:11:26 -0700 (PDT) From: Jernej Skrabec To: wens@kernel.org Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 06/13] drm/sun4i: tcon: Drop TCON TOP device reference Date: Mon, 3 Aug 2026 18:10:44 +0200 Message-ID: <871a3108086c15a483eef23301984c8d2254dfa7.1785772659.git.jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_find_device_by_node() takes a device reference. Drop it after mux configuration succeeds. Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON") Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index ea7c90fef316..de2d66623f7a 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -1409,7 +1409,7 @@ static int sun8i_r40_tcon_tv_set_mux(struct sun4i_tcon *tcon, { struct device_node *port, *remote; struct platform_device *pdev; - int id, ret; + int id, ret = 0; /* find TCON TOP platform device and TCON id */ @@ -1432,21 +1432,20 @@ static int sun8i_r40_tcon_tv_set_mux(struct sun4i_tcon *tcon, if (IS_ENABLED(CONFIG_DRM_SUN8I_TCON_TOP) && encoder->encoder_type == DRM_MODE_ENCODER_TMDS) { ret = sun8i_tcon_top_set_hdmi_src(&pdev->dev, id); - if (ret) { - put_device(&pdev->dev); - return ret; - } + if (ret) + goto out_put_device; } if (IS_ENABLED(CONFIG_DRM_SUN8I_TCON_TOP)) { ret = sun8i_tcon_top_de_config(&pdev->dev, tcon->id, id); - if (ret) { - put_device(&pdev->dev); - return ret; - } + if (ret) + goto out_put_device; } - return 0; +out_put_device: + put_device(&pdev->dev); + + return ret; } static const struct sun4i_tcon_quirks sun4i_a10_quirks = { -- 2.43.0