mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Rishabh Bhatnagar <risbhat@amazon.com>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: hch@lst.de, axboe@fb.com, kbusch@kernel.org, mbacco@amazon.com
Subject: Re: [PATCH] nvme-pci: Set min align mask before calculating max_hw_sectors
Date: Wed, 21 Sep 2022 11:10:58 +0300	[thread overview]
Message-ID: <871c0e19-9272-e92b-28dc-a50ae705bba8@grimberg.me> (raw)
In-Reply-To: <20220920191932.22797-1-risbhat@amazon.com>


> If swiotlb is force enabled dma_max_mapping_size ends up calling
> swiotlb_max_mapping_size which takes into account the min align
> mask for the device.
> Set the min align mask for nvme driver before calling
> dma_max_mapping_size while calculating max hw sectors.

Does this fix a specific bug? if so it needs a fixes tag so it can
go to stable backports as well.

> 
> Signed-off-by: Rishabh Bhatnagar <risbhat@amazon.com>
> ---
>   drivers/nvme/host/pci.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 98864b853eef..30e71e41a0a2 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2834,6 +2834,8 @@ static void nvme_reset_work(struct work_struct *work)
>   		nvme_start_admin_queue(&dev->ctrl);
>   	}
>   
> +	dma_set_min_align_mask(dev->dev, NVME_CTRL_PAGE_SIZE - 1);
> +
>   	/*
>   	 * Limit the max command size to prevent iod->sg allocations going
>   	 * over a single page.
> @@ -2846,7 +2848,6 @@ static void nvme_reset_work(struct work_struct *work)
>   	 * Don't limit the IOMMU merged segment size.
>   	 */
>   	dma_set_max_seg_size(dev->dev, 0xffffffff);
> -	dma_set_min_align_mask(dev->dev, NVME_CTRL_PAGE_SIZE - 1);
>   
>   	mutex_unlock(&dev->shutdown_lock);
>   

  reply	other threads:[~2022-09-21  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 19:19 Rishabh Bhatnagar
2022-09-21  8:10 ` Sagi Grimberg [this message]
2022-09-22  5:58   ` Christoph Hellwig
2022-09-22 18:06     ` Bhatnagar, Rishabh
2022-09-27 17:23 Rishabh Bhatnagar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871c0e19-9272-e92b-28dc-a50ae705bba8@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mbacco@amazon.com \
    --cc=risbhat@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®