From: Jonathan Cameron <jic23@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>,
Quentin Schulz <quentin.schulz@free-electrons.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: sun4i: add THERMAL dependency
Date: Sun, 2 Apr 2017 11:38:47 +0100 [thread overview]
Message-ID: <871e2c8f-b81d-42ac-14b4-eb542f5b8e0a@kernel.org> (raw)
In-Reply-To: <20170328100855.3982514-1-arnd@arndb.de>
On 28/03/17 11:07, Arnd Bergmann wrote:
> With CONFIG_THERMAL=m and CONFIG_SUN4I_GPADC=y, we get a link error
> from calling devm_thermal_zone_of_sensor_register:
>
> drivers/iio/built-in.o: In function `sun4i_gpadc_probe':
> :(.text+0x1c284): undefined reference to `devm_thermal_zone_of_sensor_register'
>
> This adds a Kconfig dependency to ensure we can only have the ADC
> driver as built-in when this function is also built-in, or when
> we see the empty stub implementation. When the thermal code is
> a module, we can still build the adc driver as a module, too.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd,
Applied to the togreg branch of iio.git. Should be heading
to Greg later today if build tests pass on the branch.
I've added a fixes tag.
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index d0af51d7bcac..7ccbad70a617 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -562,6 +562,7 @@ config SUN4I_GPADC
> tristate "Support for the Allwinner SoCs GPADC"
> depends on IIO
> depends on MFD_SUN4I_GPADC
> + depends on THERMAL || !THERMAL_OF
> help
> Say yes here to build support for Allwinner (A10, A13 and A31) SoCs
> GPADC. This ADC provides 4 channels which can be used as an ADC or as
>
prev parent reply other threads:[~2017-04-02 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 10:07 Arnd Bergmann
2017-04-02 10:38 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871e2c8f-b81d-42ac-14b4-eb542f5b8e0a@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=fabrice.gasnier@st.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=quentin.schulz@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®