Re: [PATCH v10 3/4] arm64: dts: imx8mp-skov-revc: convert to overlays

[Steffen Trumtrar <s.trumtrar@pengutronix.de>]

On 2026-10-14 at 07:53 +02, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 14/10/2026 07:38, Steffen Trumtrar wrote:
> > 
> > Hi,
> > 
> > On 2026-10-13 at 09:31 +02, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > 
> >> On Mon, Oct 12, 2026 at 08:30:32AM +0200, Steffen Trumtrar wrote:
> >>> The i.MX8MP Skov RevC jutouch 10" and Tian 7" variants are pretty
> >>> similar, apart from the Display and touch controller.
> >>>
> >>> Move the common bindings to imx8mp-skov-revc-touch.dts and convert both
> >>> variants to use overlays applied on this base version.
> >>>
> >>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> >>> ---
> >>>  arch/arm64/boot/dts/freescale/Makefile             |  5 ++
> >>>  .../imx8mp-skov-revc-jutouch-jt101tm023.dtso       | 38 ++++++++++
> >>>  .../dts/freescale/imx8mp-skov-revc-tian-g07017.dts | 81 ----------------------
> >>>  .../freescale/imx8mp-skov-revc-tian-g07017.dtso    | 40 +++++++++++
> >>>  ...h-jt101tm023.dts => imx8mp-skov-revc-touch.dts} | 26 +++----
> >>>  5 files changed, 91 insertions(+), 99 deletions(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> >>> index 475e1ad9116e1..7c1b61249778e 100644
> >>> --- a/arch/arm64/boot/dts/freescale/Makefile
> >>> +++ b/arch/arm64/boot/dts/freescale/Makefile
> >>> @@ -707,6 +707,11 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
> >>>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
> >>>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-bd500.dtb
> >>>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-hdmi.dtb
> >>> +
> >>> +imx8mp-skov-revc-jutouch-jt101tm023-dtbs += imx8mp-skov-revc-touch.dtb \
> >>> +	imx8mp-skov-revc-jutouch-jt101tm023.dtbo
> >>> +imx8mp-skov-revc-tian-g07017-dtbs += imx8mp-skov-revc-touch.dtb \
> >>> +	imx8mp-skov-revc-tian-g07017.dtbo
> >>>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt101tm023.dtb
> >>>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-tian-g07017.dtb
> >>>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-toradex-smarc-dev.dtb
> >>> diff --git
> >>> a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt101tm023.dtso
> >>> b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt101tm023.dtso
> >>> new file mode 100644
> >>> index 0000000000000..33ddd08a7adb5
> >>> --- /dev/null
> >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt101tm023.dtso
> >>
> >> I do not understand this. This is a board, so not an overlay.
> > 
> > yes, that's what I did up until v4. New board with new dts.
> > 
> > - Link to v4: https://patch.msgid.link/20260706-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v4-0-dfc0c8827c02@pengutronix.de
> > 
> > The boards are all very similar apart from the touch panel, but they are all
> > "real" boards and don't share a SOM, so dtsi is also not correct.
> > 
> 
> So why this is not a DTS?

One could argue, that the board, the RevC-Touch, is always the same hardware and there is only a different panel connected to it. Which is what is really happening. The panel is an attached device with these boards. So, imx8mp-skov-revc-touch is the board without any touchpanel connected. This still boots and is a standalone board where you can connect different touch panels to.

So, Peng [1] and Frank [2] are correct when they suggested overlays in v4, no?

[1] https://lore.kernel.org/all/akupDXc1QA4uKfR6@shlinux89/
[2] https://lore.kernel.org/all/ak5nKnRUmOxDxgZd@SMW015318/


Best regard,
Steffen

-- 
Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |