mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Grzegorz Jaszczyk <jaszczyk@chromium.org>
Cc: linux-kernel@vger.kernel.org, dmaluka@chromium.org,
	vineethrp@chromium.org, chuanxiao.dong@intel.com,
	jaszczyk@google.com, Grzegorz Jaszczyk <jaszczyk@chromium.org>
Subject: Re: [PATCH v2 0/4] x86/apic: Switch to x2apic driver early if x2apic is enabled
Date: Sat, 17 Oct 2026 23:04:12 +0200	[thread overview]
Message-ID: <871p9oca43.ffs@fw13> (raw)
In-Reply-To: <20260924104102.3534474-1-jaszczyk@chromium.org>

On Thu, Sep 24 2026 at 10:40, Grzegorz Jaszczyk wrote:
> During early boot, the generic x86 kernel defaults to the MMIO-based
> APIC driver (apic_physflat). When booting (e.g., via kexec into a
> crashdump kernel) with x2APIC already enabled in hardware and without
> ACPI MADT probing (e.g., !CONFIG_ACPI), the APIC driver pointer remains
> set to apic_physflat until late_time_init() runs x86_64_probe_apic().
>
> Because check_x2apic() detects hardware x2APIC mode and sets
> x2apic_mode = 1, the APIC MMIO fixmap is not mapped. If a pending
> interrupt fires in the window between local_irq_enable() and
> late_time_init(), native_apic_mem_eoi() attempts to write to the
> unmapped APIC EOI MMIO address, resulting in an early boot page fault
> (#PF).
>
> This series restructures early APIC initialization and installs
> apic_x2apic_phys (or apic_noop if the APIC is disabled or built without
> CONFIG_X86_X2APIC) as the default APIC driver in apic_early_init(),
> ensuring safe MSR-based or no-op APIC accesses while still allowing
> later APIC probing (e.g., upgrading to apic_x2apic_cluster) to proceed
> normally.

Reviewed-by: Thomas Gleixner <tglx@kernel.org>

      parent reply	other threads:[~2026-10-17 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 10:40 Grzegorz Jaszczyk
2026-09-24 10:40 ` [PATCH v2 1/4] x86/apic: Rename init_apic_mappings() to apic_finalize_early_init() Grzegorz Jaszczyk
2026-09-24 10:40 ` [PATCH v2 2/4] x86/apic: Consolidate early APIC initialization into apic_early_init() Grzegorz Jaszczyk
2026-09-24 10:40 ` [PATCH v2 3/4] x86/apic: Remove redundant check from x2apic_phys_probe() Grzegorz Jaszczyk
2026-09-24 10:40 ` [PATCH v2 4/4] x86/apic: Switch to x2apic driver early if x2apic is enabled Grzegorz Jaszczyk
2026-10-17 21:04 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871p9oca43.ffs@fw13 \
    --to=tglx@kernel.org \
    --cc=chuanxiao.dong@intel.com \
    --cc=dmaluka@chromium.org \
    --cc=jaszczyk@chromium.org \
    --cc=jaszczyk@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vineethrp@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®