From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Dominique Martinet <dominique.martinet@atmark-techno.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] mtd: spinand: winbond: enable continuous read for W25N04LW
Date: Tue, 25 Aug 2026 11:09:33 +0200 [thread overview]
Message-ID: <871pbmk1ma.fsf@bootlin.com> (raw)
In-Reply-To: <20260814-w25n04lw-contread-v1-1-2968b07c962d@atmark-techno.com> (Dominique Martinet's message of "Fri, 14 Aug 2026 08:15:58 +0000")
Hi Dominique,
On 14/08/2026 at 08:15:58 GMT, Dominique Martinet <dominique.martinet@atmark-techno.com> wrote:
> This enables continuous read for W25N04LW:
> - The ops are basically the same as cont_read_cache_dual_quad_dtr_variants
> without the speed limit (this chip has no HFREQ flag that would change
> the required delays) and without DTR ops (not supported)
> - w25n0xjw_set_cont_read() can be reused
>
> Unfortunately on my system (i.MX 8ULP LPSPI) the first time continuous
> read is used spinand_read_from_cache_op() falls into this if and
> disables continuous read, so this didn't go any further:
Ah, too bad :-)
> /*
> * Dirmap accesses are allowed to toggle the CS.
> * Toggling the CS during a continuous read is forbidden.
> */
> if (nbytes && req->continuous) {
> /*
> * Spi controller with broken support of continuous
> * reading was detected. Disable future use of
> * continuous reading and return -EAGAIN to retry
> * reading within regular mode.
> */
> spinand->cont_read_possible = false;
> return -EAGAIN;
> }
>
> I'm leaving this patch for anyone who could have hardware for this (or
> eventually myself after I have time to check the SPI driver...)
>
> Fun fact:
> nanddump -C is about 9% faster than nanddump on large data (tried 10MB)
> even if continuous read is not supported.
That is strange. Is this really reproducible? Can you disable CPU PM and
try again? There should be no impact if continuous read is disabled.
Thanks,
Miquèl
next prev parent reply other threads:[~2026-08-25 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 8:15 Dominique Martinet
2026-08-25 9:09 ` Miquel Raynal [this message]
2026-08-26 9:03 ` Dominique Martinet
2026-08-26 13:08 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pbmk1ma.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=dominique.martinet@atmark-techno.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®