From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC9B838399E
	for <linux-kernel@vger.kernel.org>; Thu, 20 Aug 2026 06:52:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787208751; cv=none; b=tasl1hAuoEy0MeOF8Q/qTxL0VrpVaqVurO1WrAtQjZuY0qHACZbVAcezLNxcqE1H0QYtTFR5RN2HRcHtX01/d4Q2HAAmdG3Sz7URbp7yFujs2Cv6AaHlxgFtaFUQDiBCAcchH25J+rWfPwSAkKmPQTvefTpgWinaGBgTmjgWjIc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787208751; c=relaxed/simple;
	bh=pSXQPv5GcaDGbhtSJ+L7tTXV/zc07ASDMDus4otVXDU=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=tuOtmOk5RW5fJ5bgDkK5nE4qQi7TwGNKWssSZfNrV+pN3pDamz9YyQncWree2cCtLqOkgIm6lBa0VfaBfKMns0NkAxGKFtRuigPg1skLOuy3TMkutwCHNJjy6yhZxeSZjsPUah8SZq6nGQb0QxguGjd9l934IER7Al7bTnzM2Ns=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pl3AHNvO; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pl3AHNvO"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBE261F000E9;
	Thu, 20 Aug 2026 06:52:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787208749;
	bh=g0nyfbzrZ6C30GU5eReOnb1Dtv4hfTp3qAO5diblU3g=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date;
	b=Pl3AHNvO3VLX2EGB7EYnBRK2fTYsUrQ1az7oYDSyDrx8/9VmqHJ4VPCi5w/7WoA5t
	 bAsNAGfak0WXOR7rRMJNEiq80ihOaahYEeAPJrk5pljidL0M7Ppg/R0uwkgpzjthhm
	 U43/JuwaVt2vBDdmRXgi3H905gIr8o6w+6HKIlwrFeT5XldDCliPGum5JR5RWOZNpv
	 4XjteAfL3J32lAaqEXqyoBQFzFislGafO6ja01KBDGvFGotbPAKqgXaXXkyyJLiN8w
	 KZ5FNFcZzo2LUDc/JTweXYEfpX8MURF/srA+r1B4TvAS8KYnR+uTUrSQixc0EAMJGm
	 6lm7b9LXvE4bQ==
From: Thomas Gleixner <tglx@kernel.org>
To: Haofeng Li <920484857@qq.com>
Cc: linux-kernel@vger.kernel.org, Haofeng Li <13266079573@163.com>, Haofeng
 Li <lihaofeng@kylinos.cn>, Jason Cooper <jason@lakedaemon.net>, Marc
 Zyngier <maz@kernel.org>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 04/16] irqchip/crossbar: fix allocation and init cleanup
In-Reply-To: <tencent_A96C34482A0364BDB1B266ED697B1A817708@qq.com>
References: <20260714122351.3274006-1-lihaofeng@kylinos.cn>
 <20260714132453.3302672-1-920484857@qq.com>
 <tencent_A96C34482A0364BDB1B266ED697B1A817708@qq.com>
Date: Thu, 20 Aug 2026 08:52:26 +0200
Message-ID: <871pbtjnbp.ffs@fw13>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Tue, Jul 14 2026 at 21:24, Haofeng Li wrote:
> From: Haofeng Li <lihaofeng@kylinos.cn>
>
> crossbar_domain_alloc() returns in the middle of a multi-IRQ

Please write out 'interrupts'. This is a technical document and not a
SMS service.

> allocation without freeing IRQs and crossbar slots allocated by
> earlier iterations.
>
> If irq_domain_create_hierarchy() fails after crossbar_of_init(), the
> global crossbar object and its maps and MMIO mapping are also leaked.
>
> Roll back prior IRQs through crossbar_domain_free(), and release all
> crossbar resources when domain creation fails.
>
> Fixes: 783d31863fb8 ("irqchip: crossbar: Convert dra7 crossbar to stacked domains")
>

Stray newline.

> Signed-off-by: Haofeng Li <lihaofeng@kylinos.cn>

Thanks,

        tglx