From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A305438AC83 for ; Fri, 31 Jul 2026 13:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785502966; cv=none; b=qlfQmFy7Y3zODqCFukr7Rj7sj7RjdzPnvPHbgdYzFUXwx4Y45t8MViGrV2ZZnD+9S9tCziGQ4jnhDH9ibBmLnD0gzmgCSat50rddyED/aDTDzWunEMlvVBuec4iDJunWFPHn/c0McUR/7vsVSdVYXvWJDYA6CUnzjSgmJQ/FqCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785502966; c=relaxed/simple; bh=jyLfUDRKUGR+QzdlDRg/ygdwuaQOjB35r20qE6JtzlE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=FDb88Jd/9Cu40VjICnUs9aF7GtC7vO0b6sOFzLnBHvKCT4FOqvM2d2ymzLBk3XnG1Js60dVEGpbrkiipoDJYgag7EpQ1mu9RS7gezMH1ztKKSG11V8sxxcpUKLuWcYYkPYHik3TVYUdSRI14R/Nnq1XGrf8vleU1t/8lspD8YBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=anwmx18Q; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=X/XhCbmF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="anwmx18Q"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="X/XhCbmF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785502963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=63z+74IiNXo7CtWiuSgL8tkqVXTD4W+l7gvHsFCZ+/I=; b=anwmx18Qw8L8a13qXSoIirE9R0iGUZ3EAA2iGG+WawzB3YS8rct2m5A+cmbUV1CRFy3BEG DxUmFZQTj6jOwcrrM9BXTN/URqe8QyQlPtHVDhHN8cRNTMQvcpOs3g7RSEC+fYegG3OAve J9hiCK+Z3krALqzfPj2Bsxqq+Os+f8A= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-gqtUxAIGO6CbxECs8lR2jw-1; Fri, 31 Jul 2026 09:02:42 -0400 X-MC-Unique: gqtUxAIGO6CbxECs8lR2jw-1 X-Mimecast-MFC-AGG-ID: gqtUxAIGO6CbxECs8lR2jw_1785502961 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-c1f548718d0so126448266b.0 for ; Fri, 31 Jul 2026 06:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785502961; x=1786107761; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=63z+74IiNXo7CtWiuSgL8tkqVXTD4W+l7gvHsFCZ+/I=; b=X/XhCbmF9i7BCC2OBdzMb58AEBYPM7wzwt7jDqwk99EgqdmO4P17jdkrtBIlbmyuDy mTYHyflZRgUyclydSlxfUznLg5Xqut3/ERV6IRTMmmHxq8W69xNFKQQqdxclEf7W0m3s RYSIIxZfJ1bCn9xWEdcZLTuLaIAhuvb8kQq0guA1BDpt40xTh0xgDKhAv2im4bXVfvQe 77Q0FGeS/SIKeWuvC4eeRcTpBChjnZf/oWMqrG+N+E/GtHPOGMp78NyVxIWAFO8Tr2FJ /evnIHSENvkEtqlzrnH4ztepuWj2rZmptD+77HRoD7yA19QDRDCWncg5SKPybgOeK6BG ejAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785502961; x=1786107761; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=63z+74IiNXo7CtWiuSgL8tkqVXTD4W+l7gvHsFCZ+/I=; b=CQAJYvbpKyLr5ZliTdDkbq52GO1z4xXWTiFvOYrl/tUQVbCeiDGocOoWqAwtRAbY/J a/OvpL0AOTHBCYvW9BdxJWF6dhdnpsCW5I7LRSSYAOUKpPaNEqLKPxw7tNFWMkbdJkr5 0HiWGz7235x8dBimzm89kiHwkNoZ0QqudHJ+nd3ow5sXregZGBuu2XiHkJKPhFp8IMLE g3p/EvBxPBO7Lk7GtK3pjXKjejCyTdVHdnJBjVYDHNEX1+L36+UVtJFbCnnDklqDAVUX kJfTwiiEIcxdDKKUv72AUZXqfdrKC2Pb2U3sK6fiVOrXikZqguQtuvwfgBrhFOXFjbDl DmuQ== X-Forwarded-Encrypted: i=1; AHgh+RrTex7/mbfbSu+FnqWn1vKF6sClSZ66hdMxyZ3JG4KNbCgArmIqUFJnOu4c/KrNZVc1D8jwDT5MV4S4oWY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9r9x3KOxJqjUhSqfIrO/zPgfwac9auiCFfHCJ9fmBc7qmIvqR 5N0afxGWCacT7V34aM1KfSjeWs3Me/CCP0szkLtvmhe368kekbX4x5yQoM3EBMzLd++AJAjPlQJ 3+62djlSRgqEivEl+KDmQZJC9ZIrhyfgLww+FdZwHXJsDqOrb6mZpR3v65z0HflFo1w== X-Gm-Gg: AR+sD11TEjbX+AlErkvVF5nMzyG2DFbj7kEzti1gRJIhhXzwzLArmqlO+1q2KjlPIEb h2VfeQj6pc/K6/A7TGzNrCKmz+Z4SL4jQ9n15BFePlo/Ye94bFYNBePPXsxvXRRlnBkSwLZnJYc m3knPr5/DrZ8FRZzowBnHAwNwmCZuiFI4UmUC1YqSzZ2a3JVPrqvEScx6keecHgYHGe/4WSO6Yl mzedirJVehV3/CK8gexoVnFofzp66HoLxCGJ2lMztlqIUd/vkOvbEG4aOoEak/1/K3K6vGD5BIu OvWLzHmG8xQoBtoVWgMWIX1ed9Da3BCpygY0Aad6fDJNSU+NS7CHebJ50vgpYELhoKj2525Km6K vbv1uhrctUX2FYwhund/XC1lWw2iv+EFsZsXlQvKb8H4ijCB9aR9jxe6XAo8= X-Received: by 2002:a17:907:3e90:b0:c16:8adf:f183 with SMTP id a640c23a62f3a-c1fd23c59c7mr119265466b.14.1785502960630; Fri, 31 Jul 2026 06:02:40 -0700 (PDT) X-Received: by 2002:a17:907:3e90:b0:c16:8adf:f183 with SMTP id a640c23a62f3a-c1fd23c59c7mr119260966b.14.1785502960034; Fri, 31 Jul 2026 06:02:40 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd4562a38sm4399507f8f.21.2026.07.31.06.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 06:02:38 -0700 (PDT) From: Javier Martinez Canillas To: Jakub Turek , Helge Deller , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jakub Turek Subject: Re: [PATCH 1/2] fbdev: ssd1307fb: add support for Sino Wealth SH1107 controller In-Reply-To: <20260731-feat-sh1107-v1-1-e10977f76e6b@elsta.tech> References: <20260731-feat-sh1107-v1-0-e10977f76e6b@elsta.tech> <20260731-feat-sh1107-v1-1-e10977f76e6b@elsta.tech> Date: Fri, 31 Jul 2026 15:02:36 +0200 Message-ID: <871pcje2hf.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jakub Turek writes: Hello Jakub, > The SH1107 display controller is very similar to SSD1307 but the main > difference is that SH1107 has different memory layout and uses page mode > adressation only. > > The SH1107 relies primarily on vertical page addressing mode where the > internal 128x128 GDDRAM is split into 16 vertical pages, rather than > the horizontal/tile addressing modes natively utilized by the > SSD1306/SSD1307. > > Signed-off-by: Jakub Turek > --- The fbdev driver is obsolete and likely to be removed soon. Instead please use the KMS driver (drivers/gpu/drm/solomon/ssd130x*). This already has support for the sh1106, so adding ssh1307 support should be trivial (basically just adding an entry to the device ID tables I believe). -- Best regards, Javier Martinez Canillas Core Platforms Red Hat