From: Thomas Gleixner <tglx@linutronix.de>
To: "Michael Weiß" <michael.weiss@aisec.fraunhofer.de>,
"Andrei Vagin" <avagin@gmail.com>,
"Christian Brauner" <christian.brauner@ubuntu.com>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
linux-kernel@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Chuck Lever <chuck.lever@oracle.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [PATCH v2 2/4] time: make getboottime64 aware of time namespace
Date: Sat, 10 Oct 2020 18:37:27 +0200 [thread overview]
Message-ID: <871ri6rq9k.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <3bb1af44-4245-365d-8ef4-ce17debc476f@aisec.fraunhofer.de>
Michael,
On Sat, Oct 10 2020 at 13:50, Michael Weiß wrote:
> On 10.10.20 09:19, Andrei Vagin wrote:
>> And I think we need to consider an option to not change getbootime64 and
>> apply a timens offset right in the show_stat(fs/proc/stat.c)
>> function.
That's what I meant and failed to express correctly.
> Since the problems in softirq context mentioned from Thomas,
> I would agree to Andrei's option to just patch proc/stat.c and leave
> getboottime64 unchanged.
>
> Digging around in the kernel tree, I just found /proc/stat as the only
> place where boottime is exposed to userspace, thus it seems a valid
> option.
Yes, I thought about a wrapper function which adds the namespace offset,
but as it is the only place, open coding is fine.
Thanks,
tglx
next prev parent reply other threads:[~2020-10-10 22:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 5:39 [PATCH v2 0/4] time namespace aware system boot time Michael Weiß
2020-10-08 5:39 ` [PATCH v2 1/4] timens: additional helper function to add boottime in nsec Michael Weiß
2020-10-08 5:39 ` [PATCH v2 2/4] time: make getboottime64 aware of time namespace Michael Weiß
2020-10-09 13:28 ` Christian Brauner
2020-10-09 13:55 ` J. Bruce Fields
2020-10-09 20:08 ` Thomas Gleixner
2020-10-12 21:13 ` J. Bruce Fields
2020-10-12 21:36 ` Thomas Gleixner
2020-10-14 22:05 ` J. Bruce Fields
2020-10-16 12:37 ` Thomas Gleixner
2020-10-10 7:19 ` Andrei Vagin
2020-10-10 11:50 ` Michael Weiß
2020-10-10 16:37 ` Thomas Gleixner [this message]
2020-10-13 20:05 ` Christian Brauner
2020-10-08 5:39 ` [PATCH v2 3/4] fs/proc: apply timens offset for start_boottime of processes Michael Weiß
2020-10-08 5:39 ` [PATCH v2 4/4] selftests/timens: added selftest for /proc/stat btime Michael Weiß
2020-10-09 13:21 ` [PATCH v2 0/4] time namespace aware system boot time Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ri6rq9k.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=0x7f454c46@gmail.com \
--cc=anna.schumaker@netapp.com \
--cc=avagin@gmail.com \
--cc=bfields@fieldses.org \
--cc=christian.brauner@ubuntu.com \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.weiss@aisec.fraunhofer.de \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®