From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B7AC83003 for ; Thu, 30 Apr 2020 02:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 319AE2082E for ; Thu, 30 Apr 2020 02:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="WBBHx9n9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbgD3Ceo (ORCPT ); Wed, 29 Apr 2020 22:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726526AbgD3Ceo (ORCPT ); Wed, 29 Apr 2020 22:34:44 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB4AEC035494 for ; Wed, 29 Apr 2020 19:34:43 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49CKGQ4ZsBz9sRY; Thu, 30 Apr 2020 12:34:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1588214078; bh=BCi4c4G/ZA+9mO7Of96Qiajv3+eSTHs7JkDfkYQrlss=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WBBHx9n9lJB5ghHEmLoQc/ndI+TE1BPqxe8vSOjeC45nb3lFf2k0AMXBBL6OQnEBX h7xYd9osHiC0kFJcAf39tG76Pf8UELx65k2BDL+Oo2Tl0y05j1fiJtgHLRVASvMG7A FwctvR5cuOxfITfXOsV8+w6eo558jf8H0jUk108No0lHZkAiT+Nyn/tuR7TIuKQIs3 XY3PbTnCEyrTEQKMFfqwRSXnK/Udph2u6EzvETGGJUNnG7OVewxdpo5QlHsYFN6JXz gEWP6L/DmMUuOTnvr29OLGtVWh1qkjvpSif2RtQAD9Hg7M4zcC7PpMYTkXQARL+VRb rjJPdDYfz/bFw== From: Michael Ellerman To: Gautham R Shenoy , Tyrel Datwyler Cc: "Gautham R. Shenoy" , Nathan Lynch , Vaidyanathan Srinivasan , Kamalesh Babulal , "Naveen N. Rao" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/5] Track and expose idle PURR and SPURR ticks In-Reply-To: <20200423100213.GA23192@in.ibm.com> References: <1586249263-14048-1-git-send-email-ego@linux.vnet.ibm.com> <04b5e2fa-089f-93c9-cde9-33a930455bb2@linux.ibm.com> <20200423100213.GA23192@in.ibm.com> Date: Thu, 30 Apr 2020 12:34:52 +1000 Message-ID: <871ro5g0qb.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gautham R Shenoy writes: > On Mon, Apr 20, 2020 at 03:46:35PM -0700, Tyrel Datwyler wrote: >> On 4/7/20 1:47 AM, Gautham R. Shenoy wrote: >> > From: "Gautham R. Shenoy" >> > >> > Hi, >> > >> > This is the fifth version of the patches to track and expose idle PURR >> > and SPURR ticks. These patches are required by tools such as lparstat >> > to compute system utilization for capacity planning purposes. ... >> > >> > Gautham R. Shenoy (5): >> > powerpc: Move idle_loop_prolog()/epilog() functions to header file >> > powerpc/idle: Store PURR snapshot in a per-cpu global variable >> > powerpc/pseries: Account for SPURR ticks on idle CPUs >> > powerpc/sysfs: Show idle_purr and idle_spurr for every CPU >> > Documentation: Document sysfs interfaces purr, spurr, idle_purr, >> > idle_spurr >> > >> > Documentation/ABI/testing/sysfs-devices-system-cpu | 39 +++++++++ >> > arch/powerpc/include/asm/idle.h | 93 ++++++++++++++++++++++ >> > arch/powerpc/kernel/sysfs.c | 82 ++++++++++++++++++- >> > arch/powerpc/platforms/pseries/setup.c | 8 +- >> > drivers/cpuidle/cpuidle-pseries.c | 39 ++------- >> > 5 files changed, 224 insertions(+), 37 deletions(-) >> > create mode 100644 arch/powerpc/include/asm/idle.h >> > >> >> Reviewed-by: Tyrel Datwyler > > Thanks for reviewing the patches. > >> >> Any chance this is going to be merged in the near future? There is a patchset to >> update lparstat in the powerpc-utils package to calculate PURR/SPURR cpu >> utilization that I would like to merge, but have been holding off to make sure >> we are synced with this proposed patchset. > > Michael, could you please consider this for 5.8 ? Yes. Has it been tested on KVM at all? cheers