From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F846CA9ECF for ; Mon, 4 Nov 2019 06:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA8FF218BA for ; Mon, 4 Nov 2019 06:54:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727368AbfKDGyR (ORCPT ); Mon, 4 Nov 2019 01:54:17 -0500 Received: from mga14.intel.com ([192.55.52.115]:37896 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbfKDGyR (ORCPT ); Mon, 4 Nov 2019 01:54:17 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 22:54:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,266,1569308400"; d="scan'208";a="401512333" Received: from um.fi.intel.com (HELO um) ([10.237.72.57]) by fmsmga005.fm.intel.com with ESMTP; 03 Nov 2019 22:54:15 -0800 From: Alexander Shishkin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , alexander.shishkin@linux.intel.com Subject: Re: [GIT PULL 1/7] intel_th: gth: Fix the window switching sequence In-Reply-To: <20191104063555.GA1129732@kroah.com> References: <20191028070651.9770-1-alexander.shishkin@linux.intel.com> <20191028070651.9770-2-alexander.shishkin@linux.intel.com> <20191102171419.GA484428@kroah.com> <877e4gf998.fsf@ashishki-desk.ger.corp.intel.com> <20191104063555.GA1129732@kroah.com> Date: Mon, 04 Nov 2019 08:54:14 +0200 Message-ID: <871ruof7xl.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > On Mon, Nov 04, 2019 at 08:25:39AM +0200, Alexander Shishkin wrote: >> Greg Kroah-Hartman writes: >> >> > On Mon, Oct 28, 2019 at 09:06:45AM +0200, Alexander Shishkin wrote: >> >> Commit 8116db57cf16 ("intel_th: Add switch triggering support") added >> >> a trigger assertion of the CTS, but forgot to de-assert it at the end >> >> of the sequence. This results in window switches randomly not happening. >> >> >> >> Fix that by de-asserting the trigger at the end of the window switch >> >> sequence. >> >> >> >> Signed-off-by: Alexander Shishkin >> >> Reviewed-by: Andy Shevchenko >> >> --- >> >> drivers/hwtracing/intel_th/gth.c | 3 +++ >> >> 1 file changed, 3 insertions(+) >> > >> > Shouldn't this have a Fixes: tag and a cc: stable@ in it? >> > >> > I can add it if you say it's ok to. >> >> Fixes: yes, but cc: stable shouldn't be required if this goes into 5.4, >> because the buggy commit is in 5.4-rc1. > > 8116db57cf16 ("intel_th: Add switch triggering support") was in the 5.2 > kernel release. Ah true. Thank you for checking that. Can you then also add a CC: stable? I'll be sure to check these things next time. Thanks, -- Alex