From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E644CA9EC0 for ; Mon, 28 Oct 2019 20:57:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07E6120830 for ; Mon, 28 Oct 2019 20:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388542AbfJ1U5A (ORCPT ); Mon, 28 Oct 2019 16:57:00 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:46850 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728022AbfJ1U47 (ORCPT ); Mon, 28 Oct 2019 16:56:59 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K8wx210045TFNlm038wxR7; Mon, 28 Oct 2019 21:56:57 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 21:56:57 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Mark Brown , alsa-devel@alsa-project.org Subject: Re: [PATCH 18/46] ARM: pxa: corgi: use gpio descriptors for audio References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-18-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 21:56:56 +0100 In-Reply-To: <20191018154201.1276638-18-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:33 +0200") Message-ID: <871ruwmvvr.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann > @@ -41,6 +40,8 @@ > static int corgi_jack_func; > static int corgi_spk_func; > > +struct gpio_desc *gpiod_mute_l, *gpiod_mute_r, *gpiod_apm_on, > *gpiod_mic_bias; Can't this be static ? Otherwise : Acked-by: Robert Jarzmik Cheers. -- Robert