From: Michael Ellerman <mpe@ellerman.id.au>
To: "Jan H. Schönherr" <jschoenh@amazon.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: sachinp@linux.vnet.ibm.com, kvm@vger.kernel.org,
"Jan H. Schönherr" <jschoenh@amazon.de>,
linux-kernel@vger.kernel.org,
"Abdul Haleem" <abdhalee@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD"
Date: Mon, 18 Sep 2017 16:44:32 +1000 [thread overview]
Message-ID: <871sn4jyjz.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1505592744-31498-1-git-send-email-jschoenh@amazon.de>
"Jan H. Schönherr" <jschoenh@amazon.de> writes:
> This reverts commit 36ae3c0a36b7456432fedce38ae2f7bd3e01a563.
>
> The commit broke compilation on !CONFIG_HAVE_KVM_IRQ_ROUTING. Also,
> there may be cases with CONFIG_HAVE_KVM_IRQ_ROUTING, where larger
> gsi values make sense.
>
> As the commit was meant as an early indicator to user space that
> something is wrong, reverting just restores the previous behavior
> where overly large values are ignored when encountered (without
> any direct feedback).
>
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Jan H. Schönherr <jschoenh@amazon.de>
> ---
> virt/kvm/eventfd.c | 2 --
> 1 file changed, 2 deletions(-)
Can someone merge this or preferably just send it straight to Linus, the
original patch has broken the powerpc build in mainline.
cheers
prev parent reply other threads:[~2017-09-18 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 16:24 [mainline][bisected 36ae3c0] Build fail at virt/kvm/eventfd.c:568 Abdul Haleem
2017-09-16 17:46 ` Jan H. Schönherr
2017-09-16 20:12 ` [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD" Jan H. Schönherr
2017-09-18 6:44 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sn4jyjz.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=jschoenh@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sachinp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®