From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Chunyan Zhang <zhang.chunyan@linaro.org>,
rostedt@goodmis.org, mathieu.poirier@linaro.org,
mingo@redhat.com
Cc: mike.leach@arm.com, tor@ti.com, philippe.langlais@st.com,
nicolas.guion@st.com, felipe.balbi@linux.intel.com,
zhang.lyra@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace
Date: Fri, 18 Nov 2016 16:45:13 +0200 [thread overview]
Message-ID: <871sy8g83q.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <1479438454-28650-4-git-send-email-zhang.chunyan@linaro.org>
Chunyan Zhang <zhang.chunyan@linaro.org> writes:
> If CONFIG_STM_SOURCE_FTRACE is selected, Function trace data can be writen
> to sink via STM, all functions that related to writing data packets to
> STM should be marked 'notrace' to avoid being traced by Ftrace, otherwise
> the program would stall into an endless loop.
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> drivers/hwtracing/coresight/coresight-stm.c | 2 +-
> drivers/hwtracing/intel_th/sth.c | 11 +++++++----
> drivers/hwtracing/stm/core.c | 7 ++++---
> drivers/hwtracing/stm/dummy_stm.c | 2 +-
> include/linux/stm.h | 4 ++--
> 5 files changed, 15 insertions(+), 11 deletions(-)
Quick nit: can you please split this one in 4: one for Coresight, one
for Intel TH, one for stm/dummy and one for stm/core?
I'd like to keep the bisectability. Otherwise, this is fine by me:
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Regards,
--
Alex
next prev parent reply other threads:[~2016-11-18 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 3:07 [PATCH V8 0/3] Integration of function trace with System Trace IP blocks Chunyan Zhang
2016-11-18 3:07 ` [PATCH V8 1/3] tracing: add a possibility of exporting function trace to other places instead of ring buffer only Chunyan Zhang
2016-11-18 14:29 ` Steven Rostedt
2016-11-18 14:57 ` Alexander Shishkin
2016-11-18 16:45 ` Steven Rostedt
2016-11-21 3:18 ` Chunyan Zhang
2016-11-18 3:07 ` [PATCH V8 2/3] stm class: ftrace: Add ftrace-export-over-stm driver Chunyan Zhang
2016-11-18 14:45 ` Alexander Shishkin
2016-11-18 3:07 ` [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace Chunyan Zhang
2016-11-18 14:45 ` Alexander Shishkin [this message]
2016-11-21 2:24 ` Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sy8g83q.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=nicolas.guion@st.com \
--cc=philippe.langlais@st.com \
--cc=rostedt@goodmis.org \
--cc=tor@ti.com \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®