From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755469AbcIMMnR (ORCPT ); Tue, 13 Sep 2016 08:43:17 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:55057 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754745AbcIMMnO (ORCPT ); Tue, 13 Sep 2016 08:43:14 -0400 X-IronPort-AV: E=Sophos;i="5.30,328,1470726000"; d="scan'208";a="223988749" X-IronPort-AV: E=McAfee;i="5700,7163,8286"; a="1222233952" From: "Valo, Kalle" To: Joe Perches CC: "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [PATCH] ath10k: Spelling and miscellaneous neatening Thread-Topic: [PATCH] ath10k: Spelling and miscellaneous neatening Thread-Index: AQHSAhoQ6K3Qf5pDh0uR86E8KTbd+g== Date: Tue, 13 Sep 2016 12:43:09 +0000 Message-ID: <871t0oj7hf.fsf@kamboji.qca.qualcomm.com> References: <95a6b65277914d88178ed2b15e182455067cca60.1472490319.git.joe@perches.com> In-Reply-To: <95a6b65277914d88178ed2b15e182455067cca60.1472490319.git.joe@perches.com> (Joe Perches's message of "Mon, 29 Aug 2016 10:05:51 -0700") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="us-ascii" Content-ID: <8382662410357845AE0CE0EAA6DBD7A6@qualcomm.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8DChPMD022794 Joe Perches writes: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches [...] > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -2118,7 +2118,7 @@ err: > /* TODO: It's probably a good idea to release device from the driver > * but calling device_release_driver() here will cause a deadlock. > */ > - return; > + ; > } I don't think this improves anything, I dropped this part from the patch in my pending branch. -- Kalle Valo