From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964914AbcHaO6E (ORCPT ); Wed, 31 Aug 2016 10:58:04 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:50658 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935556AbcHaO57 (ORCPT ); Wed, 31 Aug 2016 10:57:59 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 1/3] net: dsa: add MDB support In-Reply-To: <20160831143315.GD15078@lunn.ch> References: <20160829203246.18811-1-vivien.didelot@savoirfairelinux.com> <20160829203246.18811-2-vivien.didelot@savoirfairelinux.com> <20160831132534.GA15078@lunn.ch> <87vayhvx0m.fsf@ketchup.mtl.sfl> <20160831143315.GD15078@lunn.ch> User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) Date: Wed, 31 Aug 2016 10:57:27 -0400 Message-ID: <871t157zqg.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, Andrew Lunn writes: >> > Does the bridge code use multicast group when referring to L2? >> >> The switchdev MDB attribute is very similary to the FDB attribute. It >> contains the VLAN ID and the Ethernet MAC address of the group. > > I'm just trying to avoid the use of 'multicast group' for a L2 entity, > unless it is already widespread used so in the bridge code. If the > bridge code does consider L2 a 'multciast group', fine, lets document > it so. But if the bridge code only uses 'multciast group' to mean L3, > we should not use it here for L2. I am not quite sure about that. I can see that SWITCHDEV_OBJ_ID_PORT_MDB is only crafted in net/bridge/br_mdb.c:__br_mdb_notify(). What should we do if the bridge code consider a multicast group as L3? Thanks, Vivien