mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Heiner Kallweit <hkallweit1@gmail.com>, Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] HID: remove ThingM blink(1) driver
Date: Wed, 22 Jun 2016 16:03:59 -0400	[thread overview]
Message-ID: <871t3pkn2o.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <f9d5885f-b0a2-6343-f88d-693b891b0464@gmail.com>

Hi Heiner,

Heiner Kallweit <hkallweit1@gmail.com> writes:

>>> Also adding Vivien Didelot to CC, as the author of the original driver. 
>>> Vivien, the full set can be found in linux-input archives ( 
>>> http://marc.info/?l=linux-input&r=1&b=201606&w=2 )
>> 
>> Thanks a lot for the follow-up Jiri.
>> 
>> If you guys decide to remove hid-thingm.c, you need to update the
>> MAINTAINERS entry, checkpatch.pl should have warned about that.
>> 
> Right, thanks for the hint.
>
>> I can hardly test the patchset now. Heiner, can you confirm me that with
>> your patchset, we will still see 3 led_classdev in sysfs for the
>> blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)?
>> 
> Yes, this will still be the case.

Looks good to me then! Please Cc' me in the v2 so I can hack the change.

Thanks,

        Vivien

  reply	other threads:[~2016-06-22 20:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f8c59082-d76c-73aa-70b6-7454b731a055@gmail.com>
2016-06-22 13:25 ` Jiri Kosina
2016-06-22 15:42   ` Vivien Didelot
2016-06-22 19:54     ` Heiner Kallweit
2016-06-22 20:03       ` Vivien Didelot [this message]
2016-06-22 19:52   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t3pkn2o.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hkallweit1@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®