From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933160AbcAYQSF (ORCPT ); Mon, 25 Jan 2016 11:18:05 -0500 Received: from mga03.intel.com ([134.134.136.65]:23908 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932279AbcAYQSB (ORCPT ); Mon, 25 Jan 2016 11:18:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,345,1449561600"; d="scan'208";a="888863153" From: Alexander Shishkin To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] stm: add proper dependencies on the subsystem In-Reply-To: <1453737579-1960217-1-git-send-email-arnd@arndb.de> References: <1453737579-1960217-1-git-send-email-arnd@arndb.de> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 25 Jan 2016 18:17:58 +0200 Message-ID: <871t95hbux.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > As several people have pointed out, the Kconfig dependencies for > stm are confusing, because you can enable the individual features > even when the subsystem itself is disabled. > > It turns out that randconfig tests even show the a build-time > bug because of this: > > drivers/hwtracing/stm/built-in.o: In function `dummy_stm_init': > drivers/hwtracing/stm/dummy_stm.c:53: undefined reference to `stm_register_device' > drivers/hwtracing/stm/built-in.o: In function `dummy_stm_exit': > drivers/hwtracing/stm/dummy_stm.c:58: undefined reference to `stm_unregister_device' > drivers/hwtracing/stm/built-in.o:(.debug_addr+0x14): undefined reference to `stm_register_device' > drivers/hwtracing/stm/built-in.o:(.debug_addr+0x1c): undefined reference to `stm_unregister_device' > > This adds the missing 'depends on STM' lines. > > Signed-off-by: Arnd Bergmann > Fixes: 2c41538191e1 ("stm class: dummy_stm: Add dummy driver for testing stm class") http://marc.info/?l=linux-kernel&m=144680658616967 Unfortunately I wasn't able to get any fixes in 4.4 or anywhere else so far. Thanks, -- Alex